Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullable attributes/parameter checks for query #19119

Merged
merged 1 commit into from
Dec 8, 2019
Merged

Add nullable attributes/parameter checks for query #19119

merged 1 commit into from
Dec 8, 2019

Commits on Dec 8, 2019

  1. Add nullable attributes/parameter checks for query 

    Fixes #16705

Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs.

There may be some mistakes here; I plan to do a bit more static analysis after the initial merge.

Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.
    @ajcvickers
    ajcvickers committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    78b0a11 View commit details
    Browse the repository at this point in the history