Robust ordering on key properties #19644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed #19650 in case you want to tackle it too |
AndriySvyryd
approved these changes
Jan 26, 2020
Fixes #13507 Fixes #19638 See also #19641 Basic logic is: * If model type implements some sort of IComparable, then use it * Otherwise, if provider type implement some sore of IComparable, then use it * Otherwise fail in model validation Also added new test suite specifically for different types of keys with and without conversions.
ajcvickers
force-pushed
the
BuiltInDataTypesTests1225
branch
from
45fee53
to
f03be5d
Compare
ajcvickers
added a commit
that referenced
this pull request
Jan 27, 2020
… for arrays See PR discussion: #19644 (review)
ajcvickers
added a commit
that referenced
this pull request
Jan 27, 2020
… for arrays See PR discussion: #19644 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13507
Fixes #19638
See also #19641
Basic logic is:
Also added new test suite specifically for different types of keys with and without conversions.