Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust ordering on key properties #19644

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Robust ordering on key properties #19644

merged 1 commit into from
Jan 26, 2020

Commits on Jan 26, 2020

  1. Robust ordering on key properties 

    Fixes #13507
Fixes #19638

See also #19641

Basic logic is:
* If model type implements some sort of IComparable, then use it
* Otherwise, if provider type implement some sore of IComparable, then use it
* Otherwise fail in model validation

Also added new test suite specifically for different types of keys with and without conversions.
    @ajcvickers
    ajcvickers committed Jan 26, 2020
    Configuration menu
    Copy the full SHA
    f03be5d View commit details
    Browse the repository at this point in the history