Tag with caller info #24887
Merged
Tag with caller info #24887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling last changes
getting recent changes from efcore
test/EFCore.Relational.Specification.Tests/Query/FromSqlSprocQueryTestBase.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 14, 2021 12:59
AndriySvyryd
approved these changes
May 17, 2021
|
I fail to see a test which populate the info automatically. The test added is just calling the overload with parameter values. Is this what we want? |
|
@smitpatel The test you are proposing would be very fragile and break on reformatting, I think manual verification is enough. |
|
I am not sure this works. Manual verification is also fine. |
|
It does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14176
Introducing overload for TagWith to pass caller info (file name and line number).
Adding test to cover the new functionality.