Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PULL_REQUEST_TEMPLATE.md #25069

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Update PULL_REQUEST_TEMPLATE.md #25069

merged 3 commits into from
Jun 9, 2021

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Jun 9, 2021 •
edited
Loading

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@AndriySvyryd AndriySvyryd requested a review from a team June 9, 2021 20:10
bricelam
bricelam reviewed Jun 9, 2021
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md
- [ ] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
- [ ] The code builds and tests pass locally (also verified by our automated build checks)
- [ ] Commit messages follow this format:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will probably mess up the indenting. I'm not sure you can use fences with lists and get the same rendering

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then again, it's not really rendered anyway 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used it in this PR to show how it looks

@AndriySvyryd AndriySvyryd merged commit 3090669 into main Jun 9, 2021
@AndriySvyryd AndriySvyryd deleted the AndriySvyryd-patch-1 branch June 9, 2021 23:58
@ajcvickers ajcvickers mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam left review comments

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriySvyryd @bricelam @smitpatel