Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PULL_REQUEST_TEMPLATE.md #25069

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Update PULL_REQUEST_TEMPLATE.md #25069

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e0cac6
Update PULL_REQUEST_TEMPLATE.md
AndriySvyryd Jun 9, 2021
fc20682
Uncomment the text
AndriySvyryd Jun 9, 2021
27d3b1d
Grammar fixes
AndriySvyryd Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
<!--
Please check if the PR fulfills these requirements
Please check whether the PR fulfills these requirements
-->

- [ ] The code builds and tests pass (verified by our automated build checks)
- [ ] Commit messages follow this format
- [ ] I've read the guidelines for [contributing](CONTRIBUTING.md) and seen the [walkthrough](https://youtu.be/9OMxy1wal1s?t=1869)
- [ ] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
- [ ] The code builds and tests pass locally (also verified by our automated build checks)
- [ ] Commit messages follow this format:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will probably mess up the indenting. I'm not sure you can use fences with lists and get the same rendering

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then again, it's not really rendered anyway 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used it in this PR to show how it looks

Summary of the changes
- Detail 1
- Detail 2

Fixes #bugnumber
```
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Code follows the same patterns and style as existing code in this repo

Review the guidelines for [contributing](CONTRIBUTING.md) for more details.
-->