Add Migration name check

src/EFCore.Design/Migrations/Design/MigrationsScaffolder.cs

@@ -82,6 +82,11 @@ public virtual ScaffoldedMigration ScaffoldMigration(
  {
  Check.NotEmpty(migrationName, nameof(migrationName));
 
+ if (string.Equals(migrationName, "migration", StringComparison.OrdinalIgnoreCase))
+ {
+ throw new OperationException(DesignStrings.CircularBaseClassDependency);
+ }
+
  if (Dependencies.MigrationsAssembly.FindMigrationId(migrationName) != null)
  {
  throw new OperationException(DesignStrings.DuplicateMigrationName(migrationName));

src/EFCore.Design/Properties/DesignStrings.resx

@@ -138,6 +138,9 @@
  <data name="CannotGenerateTypeQualifiedMethodCall" xml:space="preserve">
  <value>A type-qualified method call requires an instance identifier, a MethodInfo and no chained calls.</value>
  </data>
+ <data name="CircularBaseClassDependency" xml:space="preserve">
+ <value>You cannot add a migration with the name 'Migration'.</value>
+ </data>
  <data name="CompiledModelConstructorBinding" xml:space="preserve">
  <value>The entity type '{entityType}' has a custom constructor binding. This is usually caused by using proxies. Compiled model can't be generated, because dynamic proxy types are not supported. If you are not using proxies configure the custom constructor binding in '{customize}' in a partial '{className}' class instead.</value>
  </data>

src/ef/Commands/MigrationsAddCommand.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System;
 using System.Collections;
 using Microsoft.EntityFrameworkCore.Tools.Properties;
 

src/ef/Properties/Resources.resx

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
- <!-- 
- Microsoft ResX Schema 
- 
+ <!--
+ Microsoft ResX Schema
+
  Version 2.0
- 
- The primary goals of this format is to allow a simple XML format 
- that is mostly human readable. The generation and parsing of the 
- various data types are done through the TypeConverter classes 
+
+ The primary goals of this format is to allow a simple XML format
+ that is mostly human readable. The generation and parsing of the
+ various data types are done through the TypeConverter classes
  associated with the data types.
- 
+
  Example:
- 
+
  ... ado.net/XML headers & schema ...
  <resheader name="resmimetype">text/microsoft-resx</resheader>
  <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
  <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
  <comment>This is a comment</comment>
  </data>
- 
- There are any number of "resheader" rows that contain simple 
+
+ There are any number of "resheader" rows that contain simple
  name/value pairs.
- 
- Each data row contains a name, and value. The row also contains a 
- type or mimetype. Type corresponds to a .NET class that support 
- text/value conversion through the TypeConverter architecture. 
- Classes that don't support this are serialized and stored with the 
+
+ Each data row contains a name, and value. The row also contains a
+ type or mimetype. Type corresponds to a .NET class that support
+ text/value conversion through the TypeConverter architecture.
+ Classes that don't support this are serialized and stored with the
  mimetype set.
- 
- The mimetype is used for serialized objects, and tells the 
- ResXResourceReader how to depersist the object. This is currently not 
+
+ The mimetype is used for serialized objects, and tells the
+ ResXResourceReader how to depersist the object. This is currently not
  extensible. For a given mimetype the value must be set accordingly:
- 
- Note - application/x-microsoft.net.object.binary.base64 is the format 
- that the ResXResourceWriter will generate, however the reader can 
+
+ Note - application/x-microsoft.net.object.binary.base64 is the format
+ that the ResXResourceWriter will generate, however the reader can
  read any of the formats listed below.
- 
+
  mimetype: application/x-microsoft.net.object.binary.base64
- value : The object must be serialized with 
+ value : The object must be serialized with
  : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
  : and then encoded with base64 encoding.
- 
+
  mimetype: application/x-microsoft.net.object.soap.base64
- value : The object must be serialized with 
+ value : The object must be serialized with
  : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
  : and then encoded with base64 encoding.
 
  mimetype: application/x-microsoft.net.object.bytearray.base64
- value : The object must be serialized into a byte array 
+ value : The object must be serialized into a byte array
  : using a System.ComponentModel.TypeConverter
  : and then encoded with base64 encoding.
  -->