Add Migration name check

[KevRitchie]

Summary of the changes:

• Add a check during the Validate method of MigrationsAddCommand to throw a CommandException when someone tries to call their migration "migration".
• Add a new resource "CircularBaseClassDependency" to notify the user that "You cannot add a migration with the name 'Migration'".

Fixes #23222

[KevRitchie]

Hi @bricelam, does this look OK? Is there anything else I need to consider?

[bricelam]

This check should probably be a bit deeper into the internals to handle scenarios outside of the CLI and PMC tools. Probably here:

efcore/src/EFCore.Design/Migrations/Design/MigrationsScaffolder.cs

Lines 83 to 88 in 21318f1

	Check.NotEmpty(migrationName, nameof(migrationName));
	if (Dependencies.MigrationsAssembly.FindMigrationId(migrationName) != null)
	{
	throw new OperationException(DesignStrings.DuplicateMigrationName(migrationName));
	}

[KevRitchie]

Thanks. I'll take a look 👍

[bricelam]

LGTM

[AndriySvyryd]

@bricelam Is there anything preventing this from being checked in apart from the conflict?

[bricelam]

Nope, good to merge.

[AndriySvyryd]

Thanks for your contribution