Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's no escape from those cold north winds #27050

Merged
merged 2 commits into from
Jan 14, 2022
Merged

There's no escape from those cold north winds #27050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b2a87
There's no escape from those cold north winds
ajcvickers Dec 20, 2021
ff3ade7
Review updates
ajcvickers Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/EFCore/Query/QueryContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,9 @@ public virtual void AddParameter(string name, object? value)
/// </summary>
/// <param name="standAlone">Whether a stand-alone <see cref="IStateManager" /> should be created to perform identity resolution.</param>
public virtual void InitializeStateManager(bool standAlone = false)
{
Check.DebugAssert(
_stateManager == null,
"The 'InitializeStateManager' method has been called multiple times on the current query context. This method is intended to be called only once before query enumeration starts.");

_stateManager = standAlone
=> _stateManager ??= standAlone
? new StateManager(Dependencies.StateManager.Dependencies)
: Dependencies.StateManager;
}

/// <summary>
/// This is an internal API that supports the Entity Framework Core infrastructure and not subject to
Expand Down
44 changes: 34 additions & 10 deletions test/EFCore.Cosmos.FunctionalTests/Query/NorthwindDbFunctionsQueryCosmosTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,44 @@ public NorthwindDbFunctionsQueryCosmosTest(
ClearLog();
}

public override Task Like_all_literals(bool async)
=> AssertTranslationFailed(() => base.Like_all_literals(async));
[ConditionalFact]
public virtual void Check_all_tests_overridden()
=> TestHelpers.AssertAllMethodsOverridden(GetType());

public override Task Like_all_literals_with_escape(bool async)
=> AssertTranslationFailed(() => base.Like_all_literals_with_escape(async));
public override async Task Like_all_literals(bool async)
{
await AssertTranslationFailed(() => base.Like_all_literals(async));

AssertSql();
}

public override async Task Like_all_literals_with_escape(bool async)
{
await AssertTranslationFailed(() => base.Like_all_literals_with_escape(async));

AssertSql();
}

public override async Task Like_literal(bool async)
{
await AssertTranslationFailed(() => base.Like_literal(async));

AssertSql();
}

public override async Task Like_literal_with_escape(bool async)
{
await AssertTranslationFailed(() => base.Like_literal_with_escape(async));

public override Task Like_literal(bool async)
=> AssertTranslationFailed(() => base.Like_literal(async));
AssertSql();
}

public override Task Like_literal_with_escape(bool async)
=> AssertTranslationFailed(() => base.Like_literal_with_escape(async));
public override async Task Like_identity(bool async)
{
await AssertTranslationFailed(() => base.Like_identity(async));

public override Task Like_identity(bool async)
=> AssertTranslationFailed(() => base.Like_identity(async));
AssertSql();
}

public override async Task Random_return_less_than_1(bool async)
{
Expand Down
Loading