There's no escape from those cold north winds #27050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maumar Could you take a look at this one too? Very similar to the Gears one. |
ajcvickers
force-pushed
the
YouCantHideFromTheWind1218
branch
2 times, most recently
from
8e06def
to
03031f7
Compare
maumar
reviewed
Jan 13, 2022
test/EFCore.InMemory.FunctionalTests/Query/NorthwindMiscellaneousQueryInMemoryTest.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Jan 13, 2022
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindFunctionsQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Jan 13, 2022
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindFunctionsQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
maumar
approved these changes
Jan 13, 2022
|
@ajcvickers just fix the copy-paste errors and it looks good otherwise |
Also fixes #7016: Support "non-rooted" query expressions in compiled queries.
ajcvickers
force-pushed
the
YouCantHideFromTheWind1218
branch
from
03031f7
to
ff3ade7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26088 for Northwind query tests.
Also fixes #7016: Support "non-rooted" query expressions in compiled queries.