Code cleanup #29012
Merged
Code cleanup #29012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Sep 7, 2022
| new DatabaseModelFactoryOptions(tables, schemas), | ||
| new ModelReverseEngineerOptions { UseDatabaseNames = useDatabaseNames, NoPluralize = noPluralize }, | ||
| new ModelCodeGenerationOptions | ||
| new(tables, schemas), |
There was a problem hiding this comment.
FWIW though I like target-typed construction, I'm not sure we should systematically always use it where possible - having the explicit type names makes it easier to understand what's going on in some contexts.
Maybe leave this on a case-by-case basis (i.e. no automated changing)?
There was a problem hiding this comment.
There are two settings:
We originally had the "not evident" setting to use new T(). But this was adding types back in to a lot of places where we had removed them.
| @@ -23,7 +23,9 @@ public class ModelCodeGeneratorSelector : LanguageBasedSelector<IModelCodeGenera | |||
| /// </summary> | |||
| public ModelCodeGeneratorSelector(IEnumerable<IModelCodeGenerator> services) | |||
| : base(services.Except(services.OfType<TemplatedModelGenerator>()).ToList()) | |||
| => _templatedModelGenerators = services.OfType<TemplatedModelGenerator>().ToList(); | |||
| { | |||
There was a problem hiding this comment.
Presumably because it is an assignment. There is probably a setting for this somewhere, if we care.
| mappingStrategy, entityType.DisplayName())); | ||
| } | ||
|
|
||
| ; |
ajcvickers
force-pushed
the
HappyValley0907
branch
from
8fdd61c to
5508ac5
Compare
ajcvickers
force-pushed
the
HappyValley0907
branch
from
5508ac5 to
fbb4d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28964