Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix for some minor bugs around JSON mappings #29227

Merged
merged 1 commit into from
Oct 4, 2022

Commits on Oct 3, 2022

  1. Fix for some minor bugs around JSON mappings

    #29214 - Json column: constructor with optional enum-parameter throws ArgumentException
    
    When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise
    
    #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums
    
    In convention code unwrap nullable type when testing for enum properties that we then apply converter to string
    
    #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor
    
    Unwrap nullable type from property before passing it as type to SqlExpression ctor
    
    #29219 - Json: error when trying to materialize json entity with nullable property that is missing in the json string - should materialize the property as null instead
    
    Modify ExtractJsonProperty method so that it used TryGetProperty when trying to extract nullable properties.
    
    Fixes #29214
    Fixes #29217
    Fixes #29225
    Fixes #29219
    maumar committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9b607e7 View commit details
    Browse the repository at this point in the history