[release/8.0] Revert behavior to throw when attempting to modify an unconstrained alternate key property #32523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lternate key property (#32492) Fixes #28961 Reverts #30213 for #32385 In #32385, an unconstrained alternate key was added to the model purely to make a non-identifying relationship artificially identifying. #30213 attempted to fix this by throwing that the key was being modified. However, this scenario is very similar to the case for a many-to-many join type, where the composite primary key is also not the end of any relationship, but forces the two many-to-one relationships to be identifying. I prepared a PR that would only throw if the key involved is alternate, but on reflection that doesn't seem like an appropriate distinction to make. So overall, I think we should just revert this change, which is what this PR does.
AndriySvyryd
reviewed
Dec 5, 2023
| } | ||
| else | ||
| { | ||
| if (foreignKey.IsRequired |
AndriySvyryd
approved these changes
Dec 5, 2023
|
Note that the branch is currently closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32383
Port of #32492
Description
In #28961, an unconstrained alternate key was added to the model purely to make a non-identifying relationship artificially identifying. #30213 attempted to fix this by throwing indicating that the key was being modified. However, this scenario is basically identical to the case for a many-to-many join type, where the composite primary key is also not the end of any relationship, but forces the two many-to-one relationships to be identifying. The only difference is that in one case the principal key is primary and in the other the principal key alternate.
I prepared a PR that would only throw if the key involved is alternate, but on reflection that doesn't seem like an appropriate distinction to make--a many-to-many join table could have an alternate key. At this point, I think the appropriate thing to do is revert the change made in 8 and just accept that the behavior is the way it is for historical reasons, even though we might do something different if we were working on this.
Customer impact
Exception thrown when manipulating many-to-one relationships that are being used to model many-to-many with a join table in cases where it worked before.
How found
Multiple customers reports on 8.0
Regression
Yes
Testing
Testing existed but was changed when we made the behavior change in 8.0. We just didn't recognize the full consquences of the change, which was intended to be a bug fix.
Risk
Low and quirked. It is very unlikely people are relying on the new behavior, which is to throw.