Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Revert behavior to throw when attempting to modify an unconstrained alternate key property #32523

Merged
merged 2 commits into from
Jan 3, 2024
Merged

[release/8.0] Revert behavior to throw when attempting to modify an unconstrained alternate key property #32523

merged 2 commits into from
Jan 3, 2024

Commits on Dec 5, 2023

  1. Revert behavior to throw when attempting to modify an unconstrained a… 

    …lternate key property (#32492)

Fixes #28961
Reverts #30213 for #32385

In #32385, an unconstrained alternate key was added to the model purely to make a non-identifying relationship artificially identifying. #30213 attempted to fix this by throwing that the key was being modified. However, this scenario is very similar to the case for a many-to-many join type, where the composite primary key is also not the end of any relationship, but forces the two many-to-one relationships to be identifying.

I prepared a PR that would only throw if the key involved is alternate, but on reflection that doesn't seem like an appropriate distinction to make. So overall, I think we should just revert this change, which is what this PR does.
    @ajcvickers
    ajcvickers committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f2ca2ea View commit details
    Browse the repository at this point in the history

  2. Quirk

    @ajcvickers
    ajcvickers committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    81c663c View commit details
    Browse the repository at this point in the history