Fix TPC equality check inside subquery predicate #35120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ajcvickers
reviewed
Nov 25, 2024
| } | ||
| => TryGetTable(column, out var table, out tableIndex) | ||
| ? table | ||
| : throw new InvalidOperationException($"Table not found with alias '{column.TableAlias}'"); |
There was a problem hiding this comment.
This should be a resource string.
There was a problem hiding this comment.
Yeah... Though it might actually be more of an UnreachableException (assertion), in which case we don't do resources - I'll take a look.
ajcvickers
approved these changes
Nov 25, 2024
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 25, 2024
Fixes dotnet#35118 (cherry picked from commit 3d0b86d)
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 25, 2024
Fixes dotnet#35118 (cherry picked from commit 3d0b86d)
roji
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35118