Fixing named query cache misses by adding support for collections in … #37150
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constant expression comparer
bittola
commented
Nov 12, 2025
cincuranet
requested changes
Nov 20, 2025
Contributor
cincuranet
left a comment
cincuranet
left a comment
There was a problem hiding this comment.
This is good. I posted some small requests corrections and we'll be good to go. I'll then make sure to backport it to 10.0 for servicing.
test/EFCore.Specification.Tests/Query/AdHocQueryFiltersQueryTestBase.cs
Outdated
Show resolved
Hide resolved
roji
reviewed
Nov 20, 2025
cincuranet
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing named query cache misses by adding support for collections inconstant expression comparer
fixes #37112