[release/10.0] Fixing named query cache misses by adding support for collections in constant expression comparer #37221
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constant expression comparer
cincuranet
changed the title
roji
approved these changes
Nov 21, 2025
SamMonoRT
approved these changes
Nov 21, 2025
Contributor
Author
|
cc @artl93 |
artl93
approved these changes
Nov 24, 2025
Member
artl93
left a comment
artl93
left a comment
There was a problem hiding this comment.
customer-reported perforance, low risk with quirk just in case.
Contributor
Author
|
Approved via email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37150.
Description
In EF 10 we added support for named query filters. Also with that
IgnoreQueryFilters(IReadOnlyCollection<string>)method was added. Sadly we missed the fact that our structural comparison for query caching does not handle properlyIReadOnlyCollection<string>.Customer impact
Queries that use above mentioned method are never cached in EF, resulting in subpar performance.
How found
Customer reported on 10.0 RC2.
Regression
No.
Testing
Tests added.
Risk
Low. Quirk added.