Update TFMs #4394

RussKie · 2023-09-13T05:07:12Z

Drop support for .NET Core 3.1
Add support for .NET 6.0
Run tests for only supported TFMs - i.e., net462.net6.0,net8.0

Microsoft Reviewers: Open in CodeFlow

RussKie · 2023-09-13T05:09:34Z

Directory.Build.targets

-  <!-- This target will make sure that projects targeting netcoreapp3.1 will also have the Microsoft.Extensions.Logging.Abstractions analyzer removed. -->
+  <!-- This target will make sure that projects targeting net462 will also have the Microsoft.Extensions.Logging.Abstractions analyzer removed. -->


@joperezr I kept this target because the comment in Microsoft.Extensions.Telemetry.Abstractions.csproj refers to both net462 and netcoreapp3.1:

Please let me know, if I misunderstood it, and these should be removed.

* Drop support for .NET Core 3.1 * Add support for .NET 6.0 * Run tests for only supported TFMs - i.e., net462;net6.0;net8.0

geeknoid · 2023-09-13T05:51:48Z

@RussKie Where do the warnings come from? This did these just appear as a result of an analyzer upgrade?

RussKie · 2023-09-13T05:52:00Z

There are also hundreds of TBD warnings:

error TBD: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Microsoft.Extensions.Options.Contextual.IOptionsContext' is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed. (https://aka.ms/dotnet-extensions-warnings/TBD)

These are the result of (likely because of the newer SDK?):

extensions/Directory.Build.targets

Lines 56 to 62 in 80f8c70

    
           <ItemGroup Condition="'$(Stage)' == 'dev' AND '$(OutputType)' != 'Exe' AND '$(Api)' != 'false'"> 
        
             <AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.ExperimentalAttribute"> 
        
               <_Parameter1>TBD</_Parameter1> 
        
               <_Parameter2>UrlFormat = "https://aka.ms/dotnet-extensions-warnings/{0}"</_Parameter2> 
        
               <_Parameter2_IsLiteral>true</_Parameter2_IsLiteral> 
        
             </AssemblyAttribute> 
        
           </ItemGroup>

As an immediate workaround I'm going to suppress TBD warning, but we need to generalise how the assembly-level attribute is applied based on the workstream? We'll need a mapping between workstreams and the experiment areas listed in https://github.com/dotnet/extensions/blob/main/docs/list-of-diagnostics.md. I'll raise a tracking issue.

[EDIT] Raised #4395

RussKie · 2023-09-13T05:53:54Z

@RussKie Where do the warnings come from? This did these just appear as a result of an analyzer upgrade?

The newer SDK:

   "sdk": {
-    "version": "8.0.100-rc.1.23381.2"
+    "version": "8.0.100-rc.2.23462.28"
   },

geeknoid · 2023-09-13T05:59:31Z

I think we should fix the IDE0028 warnings (I'm guessing VS can do this over the whole solution).

And please suppress the TBD warning for now, I'll find a suitable workaround.

RussKie · 2023-09-13T06:06:20Z

I think we should fix the IDE0028 warnings (I'm guessing VS can do this over the whole solution).

Sure.
Personally, I am not too fond of the new style, but I guess I may get used to it :)

…/learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0028)

…stMessage.Properties has been deprecated. Use Options instead.'

…work

RussKie · 2023-09-13T08:16:05Z

The build is green, good to merge 😉

joperezr · 2023-09-14T05:33:29Z

Thanks for fixing this @RussKie

FYI @ericstj

xakep139 · 2023-09-19T09:32:41Z

Directory.Build.props

    <ConditionalNet462 Condition="'$(CustomTargetFrameworks)' == '' OR $(CustomTargetFrameworks.Contains('net462'))">;net462</ConditionalNet462>

    <!-- All the .NET TFMs we're testing against -->
    <TestNetCoreTargetFrameworks>$(NetCoreTargetFrameworks)</TestNetCoreTargetFrameworks>
-    <TestNetCoreTargetFrameworks Condition="'$(CustomTargetFrameworks)' == ''">$(TestNetCoreTargetFrameworks);net7.0;net6.0</TestNetCoreTargetFrameworks>
+    <TestNetCoreTargetFrameworks Condition="'$(CustomTargetFrameworks)' == ''">$(TestNetCoreTargetFrameworks);net6.0</TestNetCoreTargetFrameworks>


@RussKie now this emits a warning that looks like:

Error occurred while restoring NuGet packages: Invalid restore input. The original target frameworks value must match the aliases. Original target frameworks: net8.0;net6.0;net6.0;net462, aliases: net8.0;net6.0;net462. Input files: C:\Users\...\source\dotnet-ext\test\Generators\Microsoft.Gen.AutoClient\Generated\Microsoft.Gen.AutoClient

I.e., the net6.0 TFM is listed twice for test projects that have <TargetFrameworks>$(TestNetCoreTargetFrameworks)</TargetFrameworks>

Can either you or @RussKie log an issue to fix this so that we make sure it is fixed? How come we aren't seeing this error in CI?

RussKie requested a review from geeknoid September 13, 2023 05:07

ghost assigned RussKie Sep 13, 2023

RussKie requested a review from joperezr September 13, 2023 05:07

RussKie commented Sep 13, 2023

View reviewed changes

Revise supported TFMs

c8a10ac

* Drop support for .NET Core 3.1 * Add support for .NET 6.0 * Run tests for only supported TFMs - i.e., net462;net6.0;net8.0

RussKie force-pushed the update_tfms branch from 5582a1e to c8a10ac Compare September 13, 2023 05:19

This comment was marked as resolved.

Sign in to view

RussKie added 5 commits September 13, 2023 16:28

warning IDE0028: Collection initialization can be simplified (https:/…

b389c88

…/learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0028)

Suppress TBD warnings, see dotnet#4395

71550f3

error CS0618: 'HttpRequestMessage.Properties' is obsolete: 'HttpReque…

640325d

…stMessage.Properties has been deprecated. Use Options instead.'

Fix tests

0043a77

warning NETSDK1212: IsTrimmable is not supported for the target frame…

6c2eb26

…work

RussKie force-pushed the update_tfms branch from b1988f2 to 6c2eb26 Compare September 13, 2023 07:11

geeknoid approved these changes Sep 13, 2023

View reviewed changes

RussKie merged commit b8b7166 into dotnet:release/8.0 Sep 13, 2023
5 checks passed

RussKie deleted the update_tfms branch September 13, 2023 23:31

xakep139 reviewed Sep 19, 2023

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Oct 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update TFMs #4394

Update TFMs #4394

RussKie commented Sep 13, 2023 •

edited by ghost

Loading

RussKie Sep 13, 2023

This comment was marked as resolved.

geeknoid commented Sep 13, 2023 •

edited

Loading

RussKie commented Sep 13, 2023 •

edited

Loading

RussKie commented Sep 13, 2023 •

edited

Loading

geeknoid commented Sep 13, 2023

RussKie commented Sep 13, 2023

RussKie commented Sep 13, 2023

joperezr commented Sep 14, 2023

xakep139 Sep 19, 2023

joperezr Sep 20, 2023

RussKie Sep 20, 2023

		<!-- This target will make sure that projects targeting netcoreapp3.1 will also have the Microsoft.Extensions.Logging.Abstractions analyzer removed. -->
		<!-- This target will make sure that projects targeting net462 will also have the Microsoft.Extensions.Logging.Abstractions analyzer removed. -->

Update TFMs #4394

Update TFMs #4394

Conversation

RussKie commented Sep 13, 2023 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

RussKie Sep 13, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

geeknoid commented Sep 13, 2023 • edited Loading

RussKie commented Sep 13, 2023 • edited Loading

RussKie commented Sep 13, 2023 • edited Loading

geeknoid commented Sep 13, 2023

RussKie commented Sep 13, 2023

RussKie commented Sep 13, 2023

joperezr commented Sep 14, 2023

xakep139 Sep 19, 2023

Choose a reason for hiding this comment

joperezr Sep 20, 2023

Choose a reason for hiding this comment

RussKie Sep 20, 2023

Choose a reason for hiding this comment

RussKie commented Sep 13, 2023 •

edited by ghost

Loading

geeknoid commented Sep 13, 2023 •

edited

Loading

RussKie commented Sep 13, 2023 •

edited

Loading

RussKie commented Sep 13, 2023 •

edited

Loading