Add network metrics to Resource Monitoring for Linux #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Aug 19, 2024
There was a problem hiding this comment.
We should have a doc page something similar to https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/rpc-metrics.md (not necessarily as part of this changeset).
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ITcpTableInfo.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/IFileSystem.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkMetrics.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback 📭
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
RussKie
reviewed
Aug 23, 2024
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ITcpStateInfoProvider.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ITcpStateInfoProvider.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/IFileSystem.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/IFileSystem.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/IFileSystem.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
.../Verified/LinuxNetworkUtilizationParserTests.Parser_Throws_When_Data_Is_Invalid.verified.txt
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/OSFileSystem.cs
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback 📭
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
@evgenyfedorov2 would this be the docs to update with new/updated metrics -> https://learn.microsoft.com/dotnet/core/diagnostics/built-in-metrics-diagnostics#microsoftextensionsdiagnosticsresourcemonitoring? |
RussKie
approved these changes
Aug 26, 2024
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/Linux/LinuxCountersTests.cs
Show resolved
Hide resolved
RussKie
approved these changes
Aug 26, 2024
...ies/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkMetrics.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...oft.Extensions.Diagnostics.ResourceMonitoring/Linux/Network/LinuxNetworkUtilizationParser.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Network/WindowsNetworkMetrics.cs
Outdated
Show resolved
Hide resolved
RussKie
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5356
Microsoft Reviewers: Open in CodeFlow