#6928 - Removed SByte and Byte from default case requirement and adde…

…d check for complete match. (#7445) * #6928 - Removed SByte and Byte from default case requirement and added check for complete match. * Upgrade new tests (#6928)
dotnet · Aug 29, 2019 · 783ae80 · 783ae80
1 parent 03da166
commit 783ae80
Show file tree

Hide file tree

Showing 3 changed files with 540 additions and 3 deletions.
diff --git a/src/fsharp/PatternMatchCompilation.fs b/src/fsharp/PatternMatchCompilation.fs
@@ -528,9 +528,7 @@ let (|ConstNeedsDefaultCase|_|) c =
     | Const.Decimal _
     | Const.String _
     | Const.Single _
-    |  Const.Double _
-    | Const.SByte _
-    | Const.Byte _
+    | Const.Double _
     | Const.Int16 _
     | Const.UInt16 _
     | Const.Int32 _
@@ -1084,6 +1082,8 @@ let CompilePatternBasic
 
         match simulSetOfDiscrims with
         | DecisionTreeTest.Const (Const.Bool _b) :: _ when simulSetOfCases.Length = 2 ->  None
+        | DecisionTreeTest.Const (Const.Byte _) :: _  when simulSetOfCases.Length = 256 ->  None
+        | DecisionTreeTest.Const (Const.SByte _) :: _  when simulSetOfCases.Length = 256 ->  None
         | DecisionTreeTest.Const (Const.Unit) :: _  ->  None
         | DecisionTreeTest.UnionCase (ucref, _) :: _ when  simulSetOfCases.Length = ucref.TyconRef.UnionCasesArray.Length -> None
         | DecisionTreeTest.ActivePatternCase _ :: _ -> error(InternalError("DecisionTreeTest.ActivePatternCase should have been eliminated", matchm))