Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6928 - Removed SByte and Byte from default case requirement and added check for complete match. #7445

Merged
merged 2 commits into from
Aug 29, 2019
Merged

#6928 - Removed SByte and Byte from default case requirement and added check for complete match. #7445

merged 2 commits into from
Aug 29, 2019

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Aug 24, 2019 •
edited
Loading

Fix #6928

cartermp
cartermp approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a suggested change in the test but otherwise this looks good

tests/fsharp/Compiler/Warnings/PatternMatchingWarningTests.fs Outdated Show resolved Hide resolved
@dsyme
Copy link
Contributor

dsyme commented Aug 28, 2019

That was easier to fix than I realized :)

dsyme
dsyme approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@cartermp
Copy link
Contributor

Thanks @gdziadkiewicz!

@cartermp cartermp merged commit 783ae80 into dotnet:master Aug 29, 2019
@gdziadkiewicz gdziadkiewicz deleted the feature/Exhaustive_pattern_matches_on_numeric_values_yield_compiler_warning_#6928 branch September 3, 2019 21:53
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@gdziadkiewicz @nosami
dotnet#6928 - Removed SByte and Byte from default case requirement an…
5d449d8 
…d added check for complete match. (dotnet#7445)

* dotnet#6928 - Removed SByte and Byte from default case requirement and added check for complete match.

* Upgrade new tests (dotnet#6928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsyme dsyme dsyme approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exhaustive pattern matches on numeric values yield compiler warning
3 participants
@gdziadkiewicz @dsyme @cartermp