Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken on german machine because warning is given in german #1118

Closed
forki opened this issue Apr 26, 2016 · 5 comments · Fixed by #1135
Closed

Tests broken on german machine because warning is given in german #1118

forki opened this issue Apr 26, 2016 · 5 comments · Fixed by #1135

Comments

@forki
Copy link
Contributor

forki commented Apr 26, 2016

Our tests are not independent of the language settings of the developer machine.

image

Repro steps

Use german machine and run build.cmd all

Actual behaviour

Build is broken with the following changes:

image

image

image

image

@smoothdeveloper
Copy link
Contributor

is there a way to flag them and set the thread culture arbitrarily?

@enricosada
Copy link
Contributor

enricosada commented Apr 26, 2016

@smoothdeveloper yes with an internal use fsc argument LCID (used by ide), but that add a warning, so change a bit the diff of output.
i added #858 to add an additional --preferreduilang to fsc like roslyn to pass en-US, so tests can pass the language for case sensitive tests (i get same problem with italian)

problem is, the test can change culture, but we need to change culture of invoked fsc.exe (that's possibile only with an argument)

i think i need to rebase and ask for review

@forki
Copy link
Contributor Author

forki commented Apr 27, 2016

Maybe we can disable the 4 tests for non-us systems? Or we remove the part that tests the culture specific message.

@enricosada
Copy link
Contributor

enricosada commented Apr 27, 2016

the whole test is culture sensitive (diff the output of compiler) so cannot be fixed atm, but we can disable these ( nunit ignore ) on non en-US cultures. I'll send a pr, good idea @forki

@forki
Copy link
Contributor Author

forki commented Apr 30, 2016

❤️ thanks for making this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants