-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests broken on german machine because warning is given in german #1118
Comments
is there a way to flag them and set the thread culture arbitrarily? |
@smoothdeveloper yes with an internal use fsc argument problem is, the test can change culture, but we need to change culture of invoked i think i need to rebase and ask for review |
Maybe we can disable the 4 tests for non-us systems? Or we remove the part that tests the culture specific message. |
the whole test is culture sensitive (diff the output of compiler) so cannot be fixed atm, but we can disable these ( nunit ignore ) on non en-US cultures. I'll send a pr, good idea @forki |
❤️ thanks for making this work. |
Our tests are not independent of the language settings of the developer machine.
Repro steps
Use german machine and run
build.cmd all
Actual behaviour
Build is broken with the following changes:
The text was updated successfully, but these errors were encountered: