disable tests who require en culture, if current culture is not en #1135
Conversation
|
Can we make it require en-US?
|
| @@ -676,6 +682,8 @@ module Printing = | |||
| let printing flag diffFileOut expectedFileOut diffFileErr expectedFileErr = check (attempt { | |||
| let { Directory = dir; Config = cfg } = testContext () | |||
|
|
|||
| do! requireENCulture () | |||
There was a problem hiding this comment.
yes, it's temporary, until --preferreduilang is merged. After that i reenable tests,
meanwhile the appveyor/jenkins run tests anyway, so no issues.
There was a problem hiding this comment.
it disable negTest only, not all
|
yeah but I also want to run tests ;-) |
| @@ -21,6 +21,13 @@ let requireVSUltimate cfg = attempt { | |||
| // ) | |||
| } | |||
|
|
|||
| let requireENCulture () = attempt { | |||
There was a problem hiding this comment.
can we share this code with the above?
There was a problem hiding this comment.
yes, i was a bit lazy, thx @dsyme
|
@forki you are |
|
I'm de-DE ;-) I want to run all tests, but not the 4 that only work on en-US |
|
@forki that's my pr 😄 , i disable the 5 tests ( 4 |
|
very good! |
|
ok refactored out the functions |
|
that's ok for review/merge /cc @KevinRansom @dsyme |
|
what about that one? |
fix #1118
tests who require
enculture are disabled, unless culture isen