[WIP] Add --preferreduilang #858

enricosada · 2016-01-08T14:11:59Z

It's the same as internal --LCID but take the language name ( en-US ) instead of locale id ( 1033 )

i cannot add a real test because resources files are not inside this repository ( why not @KevinRansom ?), so the build is only in english

it's possible to test it with

Release\net40\bin\fsc --simulateException:fsc-oom --preferreduilang:en tests\fsharpqa\Source\CompilerOptions\fsc\preferreduilang\validCulture.fs

Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.

warning FS0075: The command-line option '--simulateException' is for test purpos
es only

error FS0193: internal error: Insufficient memory to continue the execution of t
he program.

Unhandled Exception: OutOfMemoryException.

with another language

Release\net40\bin\fsc --simulateException:fsc-oom --preferreduilang:it tests\fsharpqa\Source\CompilerOptions\fsc\preferreduilang\validCulture.fs

Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.

warning FS0075: The command-line option '--simulateException' is for test purpos
es only

error FS0193: internal error: Memoria insufficiente per continuare l'esecuzione
del programma.

Eccezione non gestita: OutOfMemoryException.

mexx · 2016-01-10T09:55:45Z

src/fsharp/CompileOptions.fs

@@ -662,6 +674,13 @@ let advancedFlagsBoth tcConfigB =
        utf8OutputFlag tcConfigB;
        fullPathsFlag tcConfigB;
        libFlag tcConfigB;
+        CompilerOption("preferreduilang", tagString, OptionString (fun s -> 


@enricosada Is there a reason why you written this option inline? For consistency reasons I would provide it as an own function like the other flags in this list.

Good idea. I'll refactor as function

OmarTawfik · 2016-01-12T00:32:35Z

@dotnet-bot test this please

OmarTawfik · 2016-01-12T02:20:21Z

@enricosada Jenkins now working on master.

enricosada · 2016-01-15T16:56:35Z

ok, done with @mexx feedback, ready to review!

enricosada · 2016-01-25T10:52:09Z

added wip beacuse i need to rebase

mexx · 2016-01-26T10:52:31Z

src/fsharp/CompileOptions.fs

+    try
+        let culture = new Globalization.CultureInfo(s)
+        if (culture.CultureTypes.HasFlag(Globalization.CultureTypes.UserCustomCulture)) then
+            // Do not use user custom cultures.


@enricosada can you elaborate why not to use user custom cultures?

Further the error message will be misleading, as the language name will be actually valid, but will be reported as not.

see dotnet/roslyn#2388 something about exception with windows 10.
i am trying to use the same implementation as roslyn

enricosada · 2016-01-26T17:09:46Z

ok, rebased, fixed merge conflicts about error numbers.
For me is ready to review/merge (removed the [WIP])

enricosada · 2016-01-27T13:05:16Z

@dotnet-bot test Jenkins Windows_NT Release please.

enricosada · 2016-01-27T13:06:08Z

nope 😢 /cc @KevinRansom @otawfik-ms

OmarTawfik · 2016-01-27T19:28:37Z

@dotnet-bot test this please

OmarTawfik · 2016-01-27T19:32:14Z

@enricosada I'm not sure if we can trigger specific jobs :(

enricosada · 2016-01-27T19:35:29Z

Dotnet/cli can do it. It's possible @mmitche ?
Btw i'll push something tomorrow trigger build

enricosada · 2016-01-27T19:36:06Z

Was worth a try 😄

mmitche · 2016-01-27T23:14:41Z

@enricosada like this: test Jenkins Windows_NT Debug

enricosada · 2016-01-28T10:17:37Z

thx @mmitche ! i tried it but maybe i need push permission or be organization member? dunno 😄

enricosada · 2016-01-28T10:18:37Z

@dotnet-bot test Jenkins Windows_NT Debug

mmitche · 2016-01-28T15:57:36Z

@enricosada Are you a member of the MS org?

enricosada · 2016-01-28T16:14:45Z

@mmitche i am not a member of MS org, it's ok like that.
I was trying because it's an useful command

mmitche · 2016-01-28T16:17:54Z

@enricosada Actually it shouldn't matter in this case. Btw the reason for the long wait times is that the elevated windows image was offline all night. We are clearing that queue now. We are also switching to an auto-scaling version. I'm targeting the elevated image to be one of the first (maybe tomorrow?) so wait times should drop dramatically.

enricosada · 2016-01-28T16:42:11Z

@mmitche thank you very much.
i have seen commit/pr newer than this one built before this pr, so i was thinking the jenkins integration was stuck, maybe this pr was only queued

TyOverby · 2016-01-28T18:40:39Z

@dotnet-bot test this please

enricosada · 2016-01-28T21:53:42Z

This pr is ok.
There is a problem with jenkins build /cc @otawfik-ms @TyOverby

"d:\j\workspace\Microsoft_visualfsharp\debug_windows_nt_prtest\tests\fsharpqa\testenv\src\ILComparer\ILComparer.fsproj" (Build target) (1) -> 10:52:45 (CoreCompile target) -> 10:52:45 d:\j\workspace\Microsoft_visualfsharp\debug_windows_nt_prtest\debug\net40\bin\Microsoft.FSharp.targets(155,9): error MSB4062: The "Fsc" task could not be loaded from the assembly d:\j\workspace\Microsoft_visualfsharp\debug_windows_nt_prtest\debug\net40\bin\FSharp.Build.dll. Could not load file or assembly 'FSharp.Core, Version=4.4.1.9055, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [d:\j\workspace\Microsoft_visualfsharp\debug_windows_nt_prtest\tests\fsharpqa\testenv\src\ILComparer\ILComparer.fsproj]

enricosada · 2016-02-03T17:20:40Z

@dotnet-bot test this please

enricosada · 2016-02-09T10:32:51Z

i'll rebase to run the whole test suite, my previous local run didnt catch error with response files, so better play safe

set current culture used by compiler for ui like messages same as --LCID, but take a culture name ( like "it-IT" ) instead of a locale id

enricosada · 2016-04-27T10:51:41Z

@dotnet-bot test this please

enricosada · 2016-04-27T14:57:14Z

ok, --preferreduilang is implemented under a PREFERRED_UI_LANG compiler directive, in alternative to --lcid. i think was implemented in coreclr branch
atm PREFERRED_UI_LANG is enabled only for coreclr

I'll change this pr to:

enable --preferreduilang to all fsc profiles, no need for PREFERRED_UI_LANG
change type of tcConfigB.preferredUiLang to CultureInfo atm is string option ( /cc @dsyme is ok? )
fsc --lcid set tcConfigB.preferredUiLang, easy because new CultureInfo(lcid) exists (that's what already do)
modify write usage of tcConfigB.lcid to set tcConfigB.preferredUiLang instead
modify read usage of tcConfig.lcid is used only to set Thread.CurrentThread.CurrentUICulture ( of CultureInfo type )
add tests of this pr to test suite, atm no tests for the argument

KevinRansom · 2016-04-29T17:56:42Z

@enricosada Let me know when this is ready to pull. And tell me what you want me to do with the test disabling PR.

enricosada · 2016-04-29T20:37:55Z

I need to do work on this one

Test disabling pr is ok

KevinRansom · 2016-05-26T18:24:34Z

Hi @enricosada ,

where do we stand with this?

Kevin

enricosada · 2016-06-06T15:16:36Z

i'll close and open a new pr when ready

msftclas added the cla-already-signed label Jan 8, 2016

mexx reviewed Jan 10, 2016
View reviewed changes

enricosada mentioned this pull request Jan 15, 2016

Failing tests in cambridge suite ( disabled now ) #813

Closed

4 tasks

enricosada changed the title ~~Add --preferreduilang~~ [WIP] Add --preferreduilang Jan 25, 2016

mexx reviewed Jan 26, 2016
View reviewed changes

enricosada force-pushed the add_preferreduilang branch from 7a9b0be to fc3aa5d Compare January 26, 2016 16:06

enricosada changed the title ~~[WIP] Add --preferreduilang~~ Add --preferreduilang Jan 26, 2016

enricosada force-pushed the add_preferreduilang branch from fc3aa5d to f11db5a Compare January 28, 2016 13:29

enricosada changed the title ~~Add --preferreduilang~~ [WIP] Add --preferreduilang Feb 9, 2016

enricosada mentioned this pull request Apr 26, 2016

Tests broken on german machine because warning is given in german #1118

Closed

enricosada force-pushed the add_preferreduilang branch from f11db5a to d16b457 Compare April 26, 2016 17:05

enricosada added 4 commits April 27, 2016 01:21

add --preferreduilang <cultureName>

d051857

set current culture used by compiler for ui like messages same as --LCID, but take a culture name ( like "it-IT" ) instead of a locale id

replace magic number, it's en-US culture LCID

1c12980

remove duplicated

42d15fb

fix

19fec16

enricosada force-pushed the add_preferreduilang branch from 5f21c61 to 19fec16 Compare April 26, 2016 23:21

enricosada closed this Jun 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add --preferreduilang #858

[WIP] Add --preferreduilang #858

enricosada commented Jan 8, 2016

mexx Jan 10, 2016

enricosada Jan 10, 2016

OmarTawfik commented Jan 12, 2016

OmarTawfik commented Jan 12, 2016

enricosada commented Jan 15, 2016

enricosada commented Jan 25, 2016

mexx Jan 26, 2016

mexx Jan 26, 2016

enricosada Jan 26, 2016

enricosada commented Jan 26, 2016

enricosada commented Jan 27, 2016

enricosada commented Jan 27, 2016

OmarTawfik commented Jan 27, 2016

OmarTawfik commented Jan 27, 2016

enricosada commented Jan 27, 2016

enricosada commented Jan 27, 2016

mmitche commented Jan 27, 2016

enricosada commented Jan 28, 2016

enricosada commented Jan 28, 2016

mmitche commented Jan 28, 2016

enricosada commented Jan 28, 2016

mmitche commented Jan 28, 2016

enricosada commented Jan 28, 2016

TyOverby commented Jan 28, 2016

enricosada commented Jan 28, 2016

enricosada commented Feb 3, 2016

enricosada commented Feb 9, 2016

enricosada commented Apr 27, 2016

enricosada commented Apr 27, 2016

KevinRansom commented Apr 29, 2016

enricosada commented Apr 29, 2016

KevinRansom commented May 26, 2016

enricosada commented Jun 6, 2016

[WIP] Add --preferreduilang #858

[WIP] Add --preferreduilang #858

Conversation

enricosada commented Jan 8, 2016

mexx Jan 10, 2016

Choose a reason for hiding this comment

enricosada Jan 10, 2016

Choose a reason for hiding this comment

OmarTawfik commented Jan 12, 2016

OmarTawfik commented Jan 12, 2016

enricosada commented Jan 15, 2016

enricosada commented Jan 25, 2016

mexx Jan 26, 2016

Choose a reason for hiding this comment

mexx Jan 26, 2016

Choose a reason for hiding this comment

enricosada Jan 26, 2016

Choose a reason for hiding this comment

enricosada commented Jan 26, 2016

enricosada commented Jan 27, 2016

enricosada commented Jan 27, 2016

OmarTawfik commented Jan 27, 2016

OmarTawfik commented Jan 27, 2016

enricosada commented Jan 27, 2016

enricosada commented Jan 27, 2016

mmitche commented Jan 27, 2016

enricosada commented Jan 28, 2016

enricosada commented Jan 28, 2016

mmitche commented Jan 28, 2016

enricosada commented Jan 28, 2016

mmitche commented Jan 28, 2016

enricosada commented Jan 28, 2016

TyOverby commented Jan 28, 2016

enricosada commented Jan 28, 2016

enricosada commented Feb 3, 2016

enricosada commented Feb 9, 2016

enricosada commented Apr 27, 2016

enricosada commented Apr 27, 2016

KevinRansom commented Apr 29, 2016

enricosada commented Apr 29, 2016

KevinRansom commented May 26, 2016

enricosada commented Jun 6, 2016