Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating dotnet interactive to FSharp.Core and FSharp.Compiler.Service 8.0.400 causes test errors #17793

Closed
KevinRansom opened this issue Sep 25, 2024 · 3 comments · Fixed by #17799
Closed

Updating dotnet interactive to FSharp.Core and FSharp.Compiler.Service 8.0.400 causes test errors #17793

KevinRansom opened this issue Sep 25, 2024 · 3 comments · Fixed by #17799
Assignees
@T-Gro
Labels
Bug Needs-Triage Regression
Milestone
Backlog

Comments

@KevinRansom
Copy link
Member

This PR in the dotnet interactive repo updates the F# packages to the latest RTM packages.

dotnet/interactive#3679

This causes tests issues for interactive:
image

image
@KevinRansom KevinRansom added this to the September-2024 milestone Sep 25, 2024
@github-actions github-actions bot modified the milestones: September-2024, Backlog Sep 25, 2024
@KevinRansom KevinRansom self-assigned this Sep 25, 2024
@vzarytovskii
Copy link
Member

vzarytovskii commented Sep 26, 2024 •
edited
Loading

Issue is caused by #16168

FYI @DedSec256

@KevinRansom @T-Gro can you please handle the revert/fix (whatever is easier). It will need to go to both 8 and 9 asap.

@T-Gro T-Gro assigned T-Gro and unassigned KevinRansom Sep 26, 2024
@T-Gro
Copy link
Member

T-Gro commented Sep 26, 2024

This reproes for FSI when used with the /usesdkrefs- flag.
Under it, the typedefiniton for "MemoryExtensions" signals that it does not contain extension methods (the regression added by #16168 ).

I will try a fix-forward rather than a revert here.

@T-Gro T-Gro mentioned this issue Sep 26, 2024
Merged
@T-Gro T-Gro linked a pull request Sep 27, 2024 that will close this issue
Bugfix for extension methods: Treat System.Private.CoreLib as a system lib for extension method search #17799
Merged
@T-Gro
Copy link
Member

T-Gro commented Sep 27, 2024

Fixed with #17799

@T-Gro T-Gro closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T-Gro T-Gro

Labels
Bug Needs-Triage Regression
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
3 participants
@vzarytovskii @KevinRansom @T-Gro