Bugfix for extension methods: Treat System.Private.CoreLib as a system lib for extension method search #17799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
abonie
approved these changes
Sep 26, 2024
|
/backport to release/dev17.11 |
This reverts commit dca40ae.
|
/backport to release/dev17.11 |
|
Started backporting to release/dev17.11: https://github.com/dotnet/fsharp/actions/runs/11057164787 |
|
@T-Gro backporting to release/dev17.11 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Treat System.Private.CoreLib as a system lib for extension method search
Applying: usessdkrefs is not a valid option for desktop compiler
Applying: notes
Using index info to reconstruct a base tree...
A docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docs/release-notes/.FSharp.Compiler.Service/9.0.200.md deleted in HEAD and modified in notes. Version notes of docs/release-notes/.FSharp.Compiler.Service/9.0.200.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0003 notes
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@T-Gro an error occurred while backporting to release/dev17.11, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
KevinRansom
approved these changes
Sep 26, 2024
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
…m lib for extension method search (dotnet#17799) * Treat System.Private.CoreLib as a system lib for extension method search * usessdkrefs is not a valid option for desktop compiler * notes * Revert "notes" This reverts commit dca40ae. * Release notes back * get rid of looksLikeSystemAssembly in ilread, it is not needed --------- Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17793
Before it, extension method resolution did not work for system assemblies if the compilation was NOT using reference assemblies.
The usesdkrefs- is a switch which dotnetinteractive uses.
Without this switch, the problem does not reproduce.