-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package updates #3679
Package updates #3679
Conversation
@jonsequitur @AbhitejJohn Could we please wait a few days before merging this change? I am not sure if the new versions in this PR ( After the deadline, main would flow into the next VS release (17.13). We would have significantly more flexibility to address any fallout from this change at that point. To be clear, I don't know that this change will cause any problems. However, unless something else is blocked on this change, I was hoping we can wait until after the deadline to find out :) |
are not the version locked for vs dependecies?
Dr Diego Colombo PhD
(he/him)
Principal software engineer
.NET Interactive<https://github.com/dotnet/interactive>
Try .NET<https://github.com/dotnet/try>
[Microsoft]
…________________________________
From: Shyam N ***@***.***>
Sent: 25 September 2024 02:48
To: dotnet/interactive ***@***.***>
Cc: Diego Colombo (he/him) ***@***.***>; Review requested ***@***.***>
Subject: Re: [dotnet/interactive] Package updates (PR #3679)
@jonsequitur<https://github.com/jonsequitur> @AbhitejJohn<https://github.com/AbhitejJohn> Could we please wait a few days before merging this change?
I am not sure if the new versions in this PR are compatible with what VS 17.12 currently ships. Since we have a deadline coming up for the 17.12 release, any package compat issues emerging from this PR on the VS side could end up blocking partner team code flow for any http editor changes that need to be merged before the deadline. This could potentially mean scrambling to fix the package compat issues on the VS side at the last moment which can often end up triggering cascading package updates in other components, looping in multiple teams and additional process overhead for last minute changes.
After the deadline, main would flow into the next VS release (17.13). We would have significantly more flexibility to address any fallout from this change at that point.
—
Reply to this email directly, view it on GitHub<#3679 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAC3WBAXYXG3P3D62SA2HOLZYII53AVCNFSM6AAAAABOY6O7T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSG4YTMMJYGA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
This reverts commit 0047f39.
2e9ee97
to
ce9ed25
Compare
No description provided.