Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates #3679

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Conversation

jonsequitur
Copy link
Contributor

No description provided.

auto-merge was automatically disabled September 24, 2024 23:06

Pull request was closed

@jonsequitur jonsequitur reopened this Sep 24, 2024
@jonsequitur jonsequitur enabled auto-merge (squash) September 24, 2024 23:06
@shyamnamboodiripad
Copy link
Contributor

shyamnamboodiripad commented Sep 25, 2024

@jonsequitur @AbhitejJohn Could we please wait a few days before merging this change?

I am not sure if the new versions in this PR (System.Drawing.Common in particular) are compatible with what VS 17.12 currently ships. Since we have a deadline coming up for the 17.12 release, any package compat issues emerging from this PR on the VS side could end up blocking partner team code flow for any http editor changes that need to be merged before the deadline. This could potentially mean scrambling to fix the package compat issues on the VS side at the last moment which can often end up triggering cascading package updates in other components, looping in multiple teams and additional process overhead for last minute changes.

After the deadline, main would flow into the next VS release (17.13). We would have significantly more flexibility to address any fallout from this change at that point.

To be clear, I don't know that this change will cause any problems. However, unless something else is blocked on this change, I was hoping we can wait until after the deadline to find out :)

@colombod
Copy link
Member

colombod commented Sep 25, 2024 via email

@jonsequitur jonsequitur closed this Oct 2, 2024
@jonsequitur jonsequitur reopened this Oct 2, 2024
@jonsequitur jonsequitur merged commit c0f9100 into dotnet:main Oct 2, 2024
4 checks passed
@colombod colombod added the Area-Build & Infrastructure Relating to this repo's build and infrastructure label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Infrastructure Relating to this repo's build and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants