Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET Core SDK projects] 15.3 preview 3: dependencies are not loaded in VS #3266

Closed
forki opened this issue Jun 27, 2017 · 31 comments
Closed

[.NET Core SDK projects] 15.3 preview 3: dependencies are not loaded in VS #3266

forki opened this issue Jun 27, 2017 · 31 comments
Labels
Area-LangService-API Bug

Comments

@forki
Copy link
Contributor

forki commented Jun 27, 2017

The following solution builds fine in ionide and from command line but VS 15.3 preview 3 complains.

image

Repro steps

Expected behavior

Showing no errors

Actual behavior

VS reports missing Fable links
@forki
Copy link
Contributor Author

forki commented Jun 27, 2017

/cc @davkean I remember that we checked that for C# together,

@isaacabraham
Copy link
Contributor

Is this paket support being broken or something else?

@forki
Copy link
Contributor Author

forki commented Jun 27, 2017

paket works fine from cmd line and in ionide

@forki
Copy link
Contributor Author

forki commented Jun 27, 2017

btw: the Solution Explorer shows the deps correctly:

image

@forki
Copy link
Contributor Author

forki commented Jun 27, 2017

Ok this is only a problem with F#. I create one C# and one F# solution with dotnet new and run paket convert-from-nuget on it. I then added Newtosoft.Json as dependency to both projects:

fsharp.zip
csharp.zip

In the C# project intellisense will show Newtonsoft namespace (takes a moment for background restore but then VS knows about it). In F# project it will not.

@forki
Copy link
Contributor Author

forki commented Jun 27, 2017 •
edited
Loading

Even if you just dotnet new console -lang f# and add the PackageReference without Paket it does not work. fsharp-nuget.zip

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2017

I think the general problem here is that the F# language service doesn't get the commandline arguments yet :-/, even though the project system and build do have them.

We're working on this for preview 4. (@brettfo is hoping to look at it this week I think).

@cartermp cartermp mentioned this issue Jun 27, 2017
Closed
@forki
Copy link
Contributor Author

forki commented Jun 27, 2017

Is this something that could be fixed here?

@enricosada enricosada mentioned this issue Jun 27, 2017
Closed
@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2017

Even though I've had it explained to me 2 or 3 times now, I forget the exact details of what needs to happen here :-/

@srivatsn or @brettfo can you elaborate?

@forki
Copy link
Contributor Author

forki commented Jun 27, 2017 via email

@enricosada
Copy link
Contributor

enricosada commented Jun 27, 2017 •
edited
Loading

yes, please @Pilchie ask to remove it from blog (cc @cartermp ) at least is not another disappoinment for F# ppl (and is annoying download a preview 5GB an nothings works)
atm neither sdk 1.0 style (fsharp.net.sdk) neither 2.0 (without) works

@cartermp
Copy link
Contributor

Which blog? Neither the .NET nor VS blogs have announced a release saying that F# support works. There are release notes which can be edited here, but that's the only thing I'm aware of.

@forki
Copy link
Contributor Author

forki commented Jun 27, 2017 via email

@enricosada
Copy link
Contributor

anyway, language service and command line args bug aside, the new roslyn project system is really lightning fast (love i can edit any imported msbuild file, not just project, and it will instantly reload)

@cartermp
Copy link
Contributor

I made the request to remove that bullet point completely from the release notes.

Just to clarify, the release notes are the only thing mentioning this. There are no blog posts or announcements for F# support here, nor will there be any going on until the multiple things we have in-flight are all merged in their respective branches.

For now, there are ways to be unblocked if you use nightly releases of the .NET CLI. Unfortunately, the entire process is horribly confusing right now because of different pieces across different products across different branches of those products being shipped into different previews.

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2017

For now, there are ways to be unblocked if you use nightly releases of the .NET CLI. Unfortunately, the entire process is horribly confusing right now because of different pieces across different products across different branches of those products being shipped into different previews.

BUT We're going to work today on getting something documenting what you need to pull from where to get this working, right @cartermp ? 😉

@cartermp
Copy link
Contributor

Yup. I'll get instructions out as a part of an announcement on this repo w.r.t .NET Core support in VS.

@cartermp
Copy link
Contributor

This is likely the same root cause as #3260, but surfacing as a different issue.

@cartermp cartermp mentioned this issue Jun 30, 2017
Closed
@bardeik
Copy link

bardeik commented Aug 21, 2017

Any idea on when this issue will be closed?
Anoying to get false errors in VS

@cartermp cartermp changed the title 15.3 preview 3: dependencies are not loaded in VS [.NET Core SDK projects] 15.3 preview 3: dependencies are not loaded in VS Aug 21, 2017
@cartermp
Copy link
Contributor

@bardeh This is for .NET Core SDK-based projects. #3425 is what should address this, though it's not complete.

@cartermp
Copy link
Contributor

cartermp commented Sep 12, 2017 •
edited
Loading

This is now fixed in #3564. (note that square is defined in another file).

all-worky

@forki
Copy link
Contributor Author

forki commented Sep 12, 2017 via email

@davkean
Copy link
Member

davkean commented Sep 12, 2017 •
edited
Loading

The CPS bits don't live in a public build yet, so no.

@forki
Copy link
Contributor Author

forki commented Sep 12, 2017 via email

@davkean
Copy link
Member

davkean commented Sep 12, 2017

Apologies, I might be conflating things - thought I was replying to a question on a different issue, I'll let @cartermp confirm.

@vasily-kirichenko
Copy link
Contributor

That's how Microsoft does OSS these days.

@davkean
Copy link
Member

davkean commented Sep 12, 2017

@vasily-kirichenko I was referring to the changes we made to core VS for F#.

It would be akin to making a change to editor or other IDE pieces - this code isn't open source, so we need to wait for a public build with these pieces. It's a tradeoff; F# community can spend time rewriting these pieces as open source (and less time on F#) or you can consume non-open source features/extension points and spend more time on F#.

@davkean
Copy link
Member

davkean commented Sep 12, 2017

As a side note, it was only the critical piece that controls the order in which source files appear in the solution tree which we had to make in the closed source tree. The extensions that add managed support are all open source.

@cartermp
Copy link
Contributor

@forki No public build right now. This required a fixed in closed-source parts of VS.

@kadmia
Copy link

kadmia commented Nov 16, 2017

Has this been fixed? I think I have the same issue. I just upgraded to 15.4.4 and still have the issue.

@cartermp
Copy link
Contributor

This is fixed in the latest 15.5 Preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@forki @enricosada @Pilchie @kadmia @vasily-kirichenko @davkean @isaacabraham @bardeik @cartermp @dsyme