Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F#: Editor features (intellisense etc) don't work after deleting ".vs" #5395

Closed
davkean opened this issue Jul 27, 2018 · 6 comments
Closed

F#: Editor features (intellisense etc) don't work after deleting ".vs" #5395

davkean opened this issue Jul 27, 2018 · 6 comments
Labels
Area-LangService-API Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Milestone
15.8

Comments

@davkean
Copy link
Member

davkean commented Jul 27, 2018

From @0x53A on July 25, 2018 12:20

grafik

  1. Create a new F# project Console App (.NET Core)

  2. Let VS do its thing, after a few seconds everything works. Do a build for good measure.
    grafik

  3. Close VS and delete the .vs directory

  4. reopen the solution: build works, but editor features don't
    grafik

  5. Restart VS one more time, after that, everything works again

Copied from original issue: dotnet/project-system#3788
@davkean
Copy link
Member Author

davkean commented Jul 27, 2018

From @Pilchie on July 25, 2018 20:16

@TIHan can you take a look at this?

@davkean
Copy link
Member Author

davkean commented Jul 27, 2018

From @TIHan on July 25, 2018 20:25

Yes, going to look at it now.

@davkean
Copy link
Member Author

davkean commented Jul 27, 2018

From @Pilchie on July 25, 2018 21:26

Leaving in 15.8 for investigations.

@davkean
Copy link
Member Author

davkean commented Jul 27, 2018

From @TIHan on July 26, 2018 0:43

I know what is happening now. F#'s language service is not being initialized unless a document has been opened. This means we miss out on all the workspace events that F#'s language service needs.

To be more specific, FSharpPackage doesn't get initialized until a F# document has been opened.

@davkean
Copy link
Member Author

davkean commented Jul 27, 2018

From @TIHan on July 26, 2018 22:21

I have a fix for this coming. It is a bug in the F# language service.

@davkean davkean mentioned this issue Jul 27, 2018
Closed
@TIHan TIHan mentioned this issue Jul 27, 2018
Closed
@cartermp cartermp added Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Area-LangService-API labels Jul 27, 2018
@cartermp cartermp added this to the 15.8 milestone Jul 27, 2018
@TIHan TIHan mentioned this issue Jul 27, 2018
Merged
agocke pushed a commit to dotnet/roslyn that referenced this issue Aug 1, 2018
@TIHan @agocke
Ensure F# package is loaded (#28901)
0baaaf5 
This ensures the F# package is loaded for CPS only projects in a solution. Seems this was an oversight.

Independent of dotnet/fsharp#5391, ensuring the F# package load fixes this issue: dotnet/fsharp#5395 - and it probably fixes other issues that we haven't discovered as a result of not loading the package.
@TIHan
Copy link
Contributor

TIHan commented Aug 2, 2018

This has been resolved.

@TIHan TIHan closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Projects
None yet
Milestone
15.8
Development

No branches or pull requests
3 participants
@davkean @TIHan @cartermp