Ensure F# package is loaded #28901
Merged
Ensure F# package is loaded #28901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
approved these changes
Jul 27, 2018
|
Now I am aware that code exists....yay. |
Pilchie
approved these changes
Jul 27, 2018
| @@ -127,6 +127,9 @@ private void EnsurePackageLoaded(string language) | |||
| case LanguageNames.VisualBasic: | |||
| shell.LoadPackage(Guids.VisualBasicPackageId, out unused); | |||
| break; | |||
| case LanguageNames.FSharp: | |||
| shell.LoadPackage(Guids.FSharpPackageId, out unused); | |||
| break; | |||
There was a problem hiding this comment.
Does Typescript need the same thing?
|
What can we do to gain confidence that there aren't more issues here? @cartermp, @KevinRansom, @brettfo - can you do some buddy testing of this change? |
|
Testing for sure. If it's worth anything, I debugged when our package gets initialized when I opened up an existing solution that doesn't have a document opened by default; and indeed the package gets loaded when the code change is in. Without it, the F# package will not initialize. |
|
@Pilchie Done a bunch of testing, seems like a good fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the F# package is loaded for CPS only projects in a solution. Seems this was an oversight.
Independent of dotnet/fsharp#5391, ensuring the F# package load fixes this issue: dotnet/fsharp#5395 - and it probably fixes other issues that we haven't discovered as a result of not loading the package.