Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure F# package is loaded #28901

Merged
merged 1 commit into from
Aug 1, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/VisualStudio/Core/Def/Guids.cs
Original file line number Diff line number Diff line change
@@ -85,6 +85,10 @@ internal static class Guids
public const string VisualBasicOptionPageNamingStyleIdString = "BCA454E0-95E4-4877-B4CB-B1D642B7BAFA";
public const string VisualBasicOptionPageIntelliSenseIdString = "04460A3B-1B5F-4402-BC6D-89A4F6F0A8D7";

public const string FSharpPackageIdString = "871D2A70-12A2-4e42-9440-425DD92A4116";

public static readonly Guid FSharpPackageId = new Guid(FSharpPackageIdString);

// from vscommon\inc\textmgruuids.h
public const string TextManagerPackageString = "F5E7E720-1401-11D1-883B-0000F87579D2";

Original file line number Diff line number Diff line change
@@ -127,6 +127,9 @@ private void EnsurePackageLoaded(string language)
case LanguageNames.VisualBasic:
shell.LoadPackage(Guids.VisualBasicPackageId, out unused);
break;
case LanguageNames.FSharp:
shell.LoadPackage(Guids.FSharpPackageId, out unused);
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Typescript need the same thing?

default:
// by default, load roslyn package for things like typescript and etc
shell.LoadPackage(Guids.RoslynPackageId, out unused);