MSI setup projects + Unified VSIX project for publishing in VS #1187
Conversation
|
@otawfik-ms 104 files ... oh my you have been busy :-) |
| @@ -13,7 +13,7 @@ echo Build and run a subset of test suites | |||
| echo. | |||
| echo Usage: | |||
| echo. | |||
| echo build.cmd ^<all^|proto^|build^|debug^|release^|diag^|compiler^|coreclr^|pcls^|vs^|ci^|ci_part1^|ci_part2^> | |||
| echo build.cmd ^<all^|proto^|build^|debug^|release^|diag^|compiler^|coreclr^|pcls^|vs^|ci^|ci_part1^|ci_part2^|microbuild^> | |||
There was a problem hiding this comment.
Could we have a setup only build that just builds the setup stuff?
There was a problem hiding this comment.
I doubt it will be of much use, since the setup basically collects most of the dlls we produce under most profiles (excelt coreclr). so it is similar to building everything.
|
@otawfik-ms , I didn't see a license.txt file deployed with it. The old installer displayed a license and dropped one on disk. I believe we should at the minimum drop the localized license.rtf. |
|
I'll make sure we drop licenses with both the MSI and the VSIX |
|
what does the merged label mean when this this PR is still open? |
|
@forki I'm not sure. @KevinRansom ? |
|
@dotnet-bot test this please |
| @@ -94,6 +94,7 @@ ossreadme*.txt | |||
| *.mdf | |||
| *.ldf | |||
| *.cto | |||
| *.vstman | |||
There was a problem hiding this comment.
What file type does this represent?
There was a problem hiding this comment.
Generated vsix manifest during build that contains information about project/item templates in the vsix: https://msdn.microsoft.com/en-us/library/mt706510.aspx
|
Great work all! |
| [<assembly:System.Runtime.CompilerServices.InternalsVisibleTo("Fsi, PublicKey=002400000480000094000000060200000024000052534131000400000100010007D1FA57C4AED9F0A32E84AA0FAEFD0DE9E8FD6AEC8F87FB03766C834C99921EB23BE79AD9D5DCC1DD9AD236132102900B723CF980957FC4E177108FC607774F29E8320E92EA05ECE4E821C0A5EFE8F1645C4C0C93C1AB99285D622CAA652C1DFAD63D745D6F2DE5F17E5EAF0FC4963D261C8A12436518206DC093344D5AD293")>] | ||
| [<assembly:System.Runtime.CompilerServices.InternalsVisibleTo("FsiAnyCPU, PublicKey=002400000480000094000000060200000024000052534131000400000100010007D1FA57C4AED9F0A32E84AA0FAEFD0DE9E8FD6AEC8F87FB03766C834C99921EB23BE79AD9D5DCC1DD9AD236132102900B723CF980957FC4E177108FC607774F29E8320E92EA05ECE4E821C0A5EFE8F1645C4C0C93C1AB99285D622CAA652C1DFAD63D745D6F2DE5F17E5EAF0FC4963D261C8A12436518206DC093344D5AD293")>] | ||
| [<assembly:System.Runtime.CompilerServices.InternalsVisibleTo("FSharp.VS.FSI, PublicKey=002400000480000094000000060200000024000052534131000400000100010007D1FA57C4AED9F0A32E84AA0FAEFD0DE9E8FD6AEC8F87FB03766C834C99921EB23BE79AD9D5DCC1DD9AD236132102900B723CF980957FC4E177108FC607774F29E8320E92EA05ECE4E821C0A5EFE8F1645C4C0C93C1AB99285D622CAA652C1DFAD63D745D6F2DE5F17E5EAF0FC4963D261C8A12436518206DC093344D5AD293")>] | ||
|
|
||
| [<assembly: ProvideCodeBase(CodeBase = @"$PackageFolder$\FSharp.Compiler.Server.Shared.dll")>] |
There was a problem hiding this comment.
Well, today I learned what ProvideCodeBaseAttribute does... For this interested: https://msdn.microsoft.com/en-us/library/microsoft.visualstudio.shell.providecodebaseattribute.aspx
| 1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `VisualStudio.FSharp.EnableOpenSource` is installed, select Uninstall | ||
| 1. Run ``debug\net40\bin\EnableOpenSource.vsix`` | ||
| 1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `Visual F# Tools` is installed, select Uninstall | ||
| 1. Run ``debug\net40\bin\VisualFSharpVsix.vsix`` |
There was a problem hiding this comment.
Thanks for the other comments below. Could you rewrite sections 4 and 5 of DEVGUIDE.md please to tell the developer what they need to do to use the freshly compiled bits (either add it to this PR or a direct edit to DEVGUIDE.md)? e.g. what is the MSI for, can they uninstall it etc.
thanks!
There was a problem hiding this comment.
DEVGUIDE was already updated to note the VSIX changes. Devs won't use the MSI during development as its only purpose is to be inserted into VS.
There was a problem hiding this comment.
Ah ok, thanks, I hadn't understood that.
@KevinRansom @Microsoft/fsharp-compiler