-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSI setup projects + Unified VSIX project for publishing in VS #1187
Changes from 39 commits
367ebc5
9dd0de4
416a385
24b27ad
6671638
0af5881
ce60884
efe9d28
80cbebe
9343f88
bcd02f7
b0689b2
6dec1c3
8297fb2
64f7d96
c5e88de
4f914e2
a7ece93
22a9053
af90c62
b278b0c
df57a31
ed5de91
5254d1e
b757790
d2eb4b2
c229973
549f0c0
656578c
ed2d519
1508e32
f216c80
13698ac
e04ef27
0ba47d6
c713aac
64fe640
47d51ff
41f5405
468f191
fe9d5bf
0abec1c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,6 +94,7 @@ ossreadme*.txt | |
*.mdf | ||
*.ldf | ||
*.cto | ||
*.vstman | ||
project.lock.json | ||
Tools/ | ||
Backup/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,13 +152,13 @@ components installed into Visual Studio 15. You can revert this step by disabli | |
|
||
For **Debug**: | ||
|
||
1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `VisualStudio.FSharp.EnableOpenSource` is installed, select Uninstall | ||
1. Run ``debug\net40\bin\EnableOpenSource.vsix`` | ||
1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `Visual F# Tools` is installed, select Uninstall | ||
1. Run ``debug\net40\bin\VisualFSharpVsix.vsix`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the other comments below. Could you rewrite sections 4 and 5 of DEVGUIDE.md please to tell the developer what they need to do to use the freshly compiled bits (either add it to this PR or a direct edit to DEVGUIDE.md)? e.g. what is the MSI for, can they uninstall it etc. thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DEVGUIDE was already updated to note the VSIX changes. Devs won't use the MSI during development as its only purpose is to be inserted into VS. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah ok, thanks, I hadn't understood that. |
||
|
||
For **Release**: | ||
|
||
1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `VisualStudio.FSharp.EnableOpenSource` is installed, select Uninstall | ||
1. Run ``release\net40\bin\EnableOpenSource.vsix`` | ||
1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `Visual F# Tools` is installed, select Uninstall | ||
1. Run ``release\net40\bin\VisualFSharpVsix.vsix`` | ||
|
||
Restart Visual Studio, it should now be running your freshly-built Visual F# IDE Tools with updated F# Interactive. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ echo Build and run a subset of test suites | |
echo. | ||
echo Usage: | ||
echo. | ||
echo build.cmd ^<all^|proto^|build^|debug^|release^|diag^|compiler^|coreclr^|pcls^|vs^|ci^|ci_part1^|ci_part2^> | ||
echo build.cmd ^<all^|proto^|build^|debug^|release^|diag^|compiler^|coreclr^|pcls^|vs^|ci^|ci_part1^|ci_part2^|microbuild^> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we have a setup only build that just builds the setup stuff? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I doubt it will be of much use, since the setup basically collects most of the dlls we produce under most profiles (excelt coreclr). so it is similar to building everything. |
||
echo. | ||
echo No arguments default to 'build' | ||
echo. | ||
|
@@ -99,6 +99,24 @@ if /i '%ARG%' == 'all' ( | |
set SKIP_EXPENSIVE_TESTS=0 | ||
) | ||
|
||
if /i '%ARG%' == 'microbuild' ( | ||
set BUILD_PROTO=1 | ||
set BUILD_NET40=1 | ||
set BUILD_CORECLR=0 | ||
set BUILD_PORTABLE=1 | ||
set BUILD_VS=1 | ||
set BUILD_SETUP=1 | ||
|
||
set TEST_COMPILERUNIT=0 | ||
set TEST_NET40_COREUNIT=0 | ||
set TEST_CORECLR=0 | ||
set TEST_PORTABLE_COREUNIT=0 | ||
set TEST_VS=0 | ||
set TEST_FSHARP_SUITE=0 | ||
set TEST_FSHARPQA_SUITE=0 | ||
set SKIP_EXPENSIVE_TESTS=1 | ||
) | ||
|
||
if /i '%ARG%' == 'proto' ( | ||
set BUILD_PROTO=1 | ||
) | ||
|
@@ -232,6 +250,7 @@ echo BUILD_NET40=%BUILD_NET40% | |
echo BUILD_CORECLR=%BUILD_CORECLR% | ||
echo BUILD_PORTABLE=%BUILD_PORTABLE% | ||
echo BUILD_VS=%BUILD_VS% | ||
echo BUILD_SETUP=%BUILD_SETUP% | ||
echo BUILD_CONFIG=%BUILD_CONFIG% | ||
echo BUILD_CONFIG_LOWERCASE=%BUILD_CONFIG_LOWERCASE% | ||
echo. | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What file type does this represent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated vsix manifest during build that contains information about project/item templates in the vsix: https://msdn.microsoft.com/en-us/library/mt706510.aspx