Better error reporting in case of object initializers

[forki]

fixes #1218

[isaacabraham]

Boah. Is that like the quickest F# compiler PR ever? :-)

[forki]

only took me so long since I worked on #1220 👅

Now back to that scanner API crap that I'm supposed to fix. I needed short break. because

[forki]

@enricosada is there a chance that we print out the err and bsl files if the diff is non-zero? Would help me a lot

[dsyme]

We only want to show the new extra message if an "id = expr" is really present in some way.

Could you add a test matrix,e.g.

Person(1) // extra argument, not equality
Person(A=b) // extra argument, id=expr equality
Person(1=b) // extra argument, not-id=expr equality
Person(A=b, C=d) // extra argument, two id=expr equality
Person(A=b
        C=d) // extra argument, two id=expr equality, no comma

and there are probably other cases to add too.

For the wording I suggest:

The object constructor '%s' takes %d argument(s) but is here given %d. The required 
signature is '%s'. If some of the arguments are assigning values to properties, consider 
separating those arguments with a comma (',').

[enricosada]

@forki what test? i think was removed because bsl/diff usually are big and just a single line addition make big diff in the output of test, fsdiff was not too smart with minimize diff.
maybe we can add to test ouput a cmd like kdiff3 path/to/file.bsl path/to/file.err ready to be executed, that's better?

[forki]

No the issue is that I don't get to that point locally. I need to see what
was wrong on CI
On May 25, 2016 7:37 PM, "Enrico Sada" notifications@github.com wrote:

@forki https://github.com/forki what test? i think was removed because
bsl/diff usually are big and just a single line addition make big diff in
the output of test, fsdiff was not too smart with minimize diff.
maybe we can add to test ouput a cmd like kdiff3 path/to/file.bsl
path/to/file.err ready to be executed, that's better?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1219 (comment)

[enricosada]

ok got it, because

<test-case name="sigs" executed="True" result="Failure" success="False" time="708.227" asserts="0">
<properties>
<property name="Category" value="typecheck/sigs"/>
<property name="Category" value="Misc02"/>
<property name="Category" value="TypeChecker"/>
<property name="Category" value="TypeCheckerSigs"/>
<property name="DIRECTORY" value="D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typecheck\sigs"/>
</properties>
<properties>...</properties>
<failure>
<message>
<![CDATA[
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharpqa\testenv\bin\diff.exe' with args 'neg15.err neg15.bsl normalize' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typecheck\sigs'. ERRORLEVEL 1 ERRORLEVEL 1
]]>

doesnt help when using ci server, right.

So i think the solution can be adding the err/bsl to build artifacts of jenkins/appveyor as additional test results, so can be downloaded (and diff).
i'll try

[forki]

Yes that would solve it as well. Thanks
On May 25, 2016 8:01 PM, "Enrico Sada" notifications@github.com wrote:

ok got it, because

...

doesnt help when using ci server, right.

So i think the solution can be adding the err/bsl to build artifacts of
jenkins/appveyor as additional test results, so can be downloaded (and
diff).
i'll try

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1219 (comment)

[forki]

@dsyme I can't find a way to distinguish the cases

Person(1) // extra argument, not equality
Person(A=b
       C=d) 

So we need to find a way or we adjust the message to include both cases.

[KevinRansom]

@forki @dsyme Is there any more to do for this PR? it has been untouched for almost 6 Months.

Thanks

Kevin

[forki]

Yes as described above I can't find a way to distinguish the two cases and need help

[forki]

ok found a way. @KevinRansom this is ready