Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect incorrect module declarations #1220

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Conversation

forki
Copy link
Contributor

@forki forki commented May 25, 2016

fixes #1214

image

@KevinRansom
Copy link
Member

Failures, probably related:
+++ Conformance\ImplementationFilesAndSignatureFiles\NamespacesFragmentsAndImplementationFiles\basic (E_NoNamespaceModuleDec02a.fs) +++
Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.
(7,1): error FS0222: Files in libraries or multiple-file applications must begin with a namespace or module declaration. When using a module declaration at the start of a file the '=' sign is not allowed. If this is a top-level module, consider removing the = to resolve this error.

*** The following necessary lines were never matched:
*** (7,1):.+error FS0222:.+Files in libraries or multiple-file applications must begin with a namespace or module declaration, e.g. 'namespace SomeNamespace.SubNamespace' or 'module SomeNamespace.SomeModule'. Only the last source file of an application may omit such a declaration.$

*** The following necessary lines were incorrectly matched:

Unexpected Compiler Output
FAIL

+++ Warnings (ModuleWithoutNamespace.fs) +++
Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.
(5,12): warning FS0988: Main module of program is empty: nothing will happen when it is run

*** The following necessary lines were never matched:
*** (10,5):.+error FS0193:.+Type constraint mismatch. The type

*** The following necessary lines were incorrectly matched:

Unexpected Compiler Output
FAIL

@forki
Copy link
Contributor Author

forki commented May 28, 2016

I will continue to work on this on Monday.
On May 28, 2016 01:34, "Kevin Ransom (msft)" notifications@github.com
wrote:

Failures, probably related:
+++
Conformance\ImplementationFilesAndSignatureFiles\NamespacesFragmentsAndImplementationFiles\basic
(E_NoNamespaceModuleDec02a.fs) +++
Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.
(7,1): error FS0222: Files in libraries or multiple-file applications must
begin with a namespace or module declaration. When using a module
declaration at the start of a file the '=' sign is not allowed. If this is
a top-level module, consider removing the = to resolve this error.

*** The following necessary lines were never matched:
*** (7,1):.+error FS0222:.+Files in libraries or multiple-file applications
must begin with a namespace or module declaration, e.g. 'namespace
SomeNamespace.SubNamespace' or 'module SomeNamespace.SomeModule'. Only the
last source file of an application may omit such a declaration.$

*** The following necessary lines were incorrectly matched:

Unexpected Compiler Output
FAIL

+++ Warnings (ModuleWithoutNamespace.fs) +++
Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.
(5,12): warning FS0988: Main module of program is empty: nothing will
happen when it is run

*** The following necessary lines were never matched:
*** (10,5):.+error FS0193:.+Type constraint mismatch. The type

*** The following necessary lines were incorrectly matched:

Unexpected Compiler Output
FAIL


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1220 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNNcyhFQL65fuOrVdMsWuPYpTU5-Wks5qF39ogaJpZM4ImlmM
.

@forki forki force-pushed the module branch 2 times, most recently from e8d10cd to 37c6e93 Compare May 30, 2016 13:42
@forki forki changed the title WIP Detect incorrect module declarations Detect incorrect module declarations May 30, 2016
@forki
Copy link
Contributor Author

forki commented May 30, 2016

I think this one is ready.

@KevinRansom
Copy link
Member

This looks great.

@KevinRansom KevinRansom merged commit 20edccb into dotnet:master Jun 1, 2016
@KevinRansom
Copy link
Member

Thanks Steffen for taking care of this.

Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error reporting: Detect module declarations that incorrectly end with =
3 participants