Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging -- Enable debugging scripts with the VS Debugger. #14537

Merged
merged 14 commits into from
Feb 14, 2023

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Jan 3, 2023

Script debugging only ever worked with the windows desktop .NET Framework fsi, it did not work with dotnet sdk fsi implementation. Last year script debugger got broken for the desktop framework.

image

This PR starts the process of repairing it, along the way it enables script debugging for as well.
Here is stepping through a script with the coreclr fsi.

image

There are still horrid bugs, watch variables doesn't work, on either platform. More work will attempt to address that.

@KevinRansom KevinRansom requested a review from a team as a code owner January 3, 2023 23:46
@KevinRansom KevinRansom changed the title Debugging -- let's see what's broke Debugging -- Enable debugging scripts with the VS Debugger. Jan 6, 2023
T-Gro
T-Gro previously approved these changes Jan 6, 2023
vzarytovskii
vzarytovskii previously approved these changes Jan 6, 2023
@KevinRansom KevinRansom dismissed stale reviews from vzarytovskii and T-Gro via 6255d54 January 9, 2023 00:48
vzarytovskii
vzarytovskii previously approved these changes Jan 9, 2023
Co-authored-by: Petr Pokorny <petr@innit.cz>
@KevinRansom KevinRansom merged commit 5217ceb into dotnet:main Feb 14, 2023
KevinRansom added a commit to KevinRansom/fsharp that referenced this pull request Feb 20, 2023
kant2002 pushed a commit to kant2002/fsharp that referenced this pull request Apr 1, 2023
…4537)

* debugging

* oops

* remove deletes

* better

* Delete pdbs

* temp

* Update src/Compiler/Interactive/fsi.fs

Co-authored-by: Petr Pokorny <petr@innit.cz>

---------

Co-authored-by: Petr Pokorny <petr@innit.cz>
@KevinRansom KevinRansom deleted the debugging branch April 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants