-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging -- Enable debugging scripts with the VS Debugger. #14537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
changed the title
Debugging -- let's see what's broke
Debugging -- Enable debugging scripts with the VS Debugger.
Jan 6, 2023
T-Gro
previously approved these changes
Jan 6, 2023
vzarytovskii
previously approved these changes
Jan 6, 2023
vzarytovskii
reviewed
Jan 9, 2023
vzarytovskii
previously approved these changes
Jan 9, 2023
KevinRansom
commented
Jan 9, 2023
KevinRansom
commented
Jan 9, 2023
This was referenced Jan 9, 2023
T-Gro
reviewed
Jan 10, 2023
T-Gro
reviewed
Jan 10, 2023
0101
reviewed
Jan 16, 2023
Co-authored-by: Petr Pokorny <petr@innit.cz>
T-Gro
approved these changes
Feb 6, 2023
0101
approved these changes
Feb 6, 2023
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
…otnet#14537)" This reverts commit 5217ceb.
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
…4537) * debugging * oops * remove deletes * better * Delete pdbs * temp * Update src/Compiler/Interactive/fsi.fs Co-authored-by: Petr Pokorny <petr@innit.cz> --------- Co-authored-by: Petr Pokorny <petr@innit.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script debugging only ever worked with the windows desktop .NET Framework fsi, it did not work with dotnet sdk fsi implementation. Last year script debugger got broken for the desktop framework.
This PR starts the process of repairing it, along the way it enables script debugging for as well.
Here is stepping through a script with the coreclr fsi.
There are still horrid bugs, watch variables doesn't work, on either platform. More work will attempt to address that.