Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checker: recover on unresolved type in 'inherit' member #16429

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Checker: recover on unresolved type in 'inherit' member #16429

merged 2 commits into from
Dec 14, 2023

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Dec 13, 2023 •
edited
Loading

Fixes skipped analysis for types with unresolved types in inherit member:

Screenshot 2023-12-13 at 16 50 04

@auduchinok auduchinok requested a review from a team as a code owner December 13, 2023 15:51
@auduchinok
Copy link
Member Author

Wow, it's all green from the first attempt. Definitely not expected that. 🙂

@vzarytovskii
Copy link
Member

Wow, it's all green from the first attempt. Definitely not expected that. 🙂

Must be something wrong

psfinaki
psfinaki approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abonie abonie merged commit f9b22ce into dotnet:main Dec 14, 2023
@auduchinok auduchinok deleted the tc-inherit branch December 14, 2023 15:34
OwnageIsMagic added a commit to OwnageIsMagic/fsharp that referenced this pull request Dec 21, 2023
@OwnageIsMagic
Merge remote-tracking branch 'upstream/main'
9246ac8 
* upstream/main: (166 commits)
  typo in foldBack summary (dotnet#16453)
  Fix for dotnet#83 (improve constraint error message) (dotnet#16304)
  Name resolution: resolve interfaces in expressions (dotnet#15660)
  AddExplicitReturnType refactoring (dotnet#16077)
  Disabling 2 tests: running for too long, causing CI timeouts
  Improve value restriction error message dotnet#1103 (dotnet#15877)
  Parens: Keep parens for non-identical infix operator pairs with same precedence (dotnet#16372)
  More release note entries (dotnet#16438)
  Using Ordinal is both faster and more correct as our intent is to do … (dotnet#16439)
  merge (dotnet#16427)
  Optimize empty string compares (dotnet#16435)
  Checker: recover on unresolved type in 'inherit' member (dotnet#16429)
  Release notes proposal (dotnet#16377)
  [main] Update dependencies from dotnet/source-build-reference-packages (dotnet#16411)
  Allow usage of [<TailCall>] with older FSharp.Core package versions (dotnet#16373)
  Parser: recover on unfinished 'as' patterns (dotnet#16404)
  Parens: Keep parens in method calls in dot-lambdas (dotnet#16395)
  Checker: check unfinished obj expression inside computations (dotnet#16413)
  Added default dotnet-tools + additional tasks to launch them (dotnet#16409)
  make `remarks` and `returns` visible in quick info (dotnet#16417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auduchinok @vzarytovskii @psfinaki @abonie