Fix #16398 - The dotnet framework has a limit of ~64K methods in a single class. #16427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
investigate
branch
2 times, most recently
from
c38a178 to
887298e
Compare
T-Gro
approved these changes
Dec 13, 2023
KevinRansom
changed the title
vzarytovskii
approved these changes
Dec 14, 2023
KevinRansom
force-pushed
the
investigate
branch
from
1d27587 to
9d9993b
Compare
|
That "64k methods ought to be good enough for anyone" fable must be true. |
OwnageIsMagic
added a commit
to OwnageIsMagic/fsharp
that referenced
this pull request
Dec 21, 2023
* upstream/main: (166 commits) typo in foldBack summary (dotnet#16453) Fix for dotnet#83 (improve constraint error message) (dotnet#16304) Name resolution: resolve interfaces in expressions (dotnet#15660) AddExplicitReturnType refactoring (dotnet#16077) Disabling 2 tests: running for too long, causing CI timeouts Improve value restriction error message dotnet#1103 (dotnet#15877) Parens: Keep parens for non-identical infix operator pairs with same precedence (dotnet#16372) More release note entries (dotnet#16438) Using Ordinal is both faster and more correct as our intent is to do … (dotnet#16439) merge (dotnet#16427) Optimize empty string compares (dotnet#16435) Checker: recover on unresolved type in 'inherit' member (dotnet#16429) Release notes proposal (dotnet#16377) [main] Update dependencies from dotnet/source-build-reference-packages (dotnet#16411) Allow usage of [<TailCall>] with older FSharp.Core package versions (dotnet#16373) Parser: recover on unfinished 'as' patterns (dotnet#16404) Parens: Keep parens in method calls in dot-lambdas (dotnet#16395) Checker: check unfinished obj expression inside computations (dotnet#16413) Added default dotnet-tools + additional tasks to launch them (dotnet#16409) make `remarks` and `returns` visible in quick info (dotnet#16417) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit a type to 65K methods.
Ensure that while writing the assembly, ensure that no type has more than approx 64K. Includes property setters/getters/constructors and event methods.
Technically this is a breaking change, however, a type with more than 64K methods, will not be loadable at runtime by the CLR, so warning on compilation is a vast improvement.
I have added a couple of test cases but we may want to disable them as they add about 8 minutes to the test execution time.
Fixes #16398