-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow access modifiers to auto properties getters and setters #16861
Allow access modifiers to auto properties getters and setters #16861
Conversation
…om/Tangent-90/fsharp into access-modifies-to-auto-properties
❗ Release notes required
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This seems to be ready, apart from conflicts. Would be good to have this in please 🙏 |
@Tangent-90 will you have time to get to this or maybe you have fresh thoughts? If no - which is understood since we didn't get to this in a timely manner - I can probably fix the conflicts and give it a proper review next week. |
Sorry for the lately response, I may try to fix it in this weekend. |
3869,featureParsedHashDirectiveUnexpectedInteger,"Unexpected integer literal '%d'." | ||
3869,featureParsedHashDirectiveUnexpectedIdentifier,"Unexpected identifier '%s'." | ||
3870,featureParsedHashDirectiveUnexpectedInteger,"Unexpected integer literal '%d'." | ||
3870,featureParsedHashDirectiveUnexpectedIdentifier,"Unexpected identifier '%s'." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhm this is probably okay but to be on the safe side I would not change warning numbers here. I know this happened because another features got introduced since this PR was created, sorry for inconvenience therefore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auduchinok if you're nearby, PTAL if you're okay with the parser changes (look reasonable to me).
@@ -1489,6 +1489,18 @@ type SynComponentInfo = | |||
/// Gets the syntax range of this construct | |||
member Range: range | |||
|
|||
/// Represents two access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Represents two access | |
/// Represents two access modifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thanks for adding the signature support and extra tests. Left a few small remarks.
Description
Fixes #16854
Checklist