-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the conflicted error number of Access-modifies-to-auto-properties
#17522
Merged
vzarytovskii
merged 70 commits into
dotnet:main
from
ijklam:access-modifies-to-auto-properties
Aug 12, 2024
Merged
Change the conflicted error number of Access-modifies-to-auto-properties
#17522
vzarytovskii
merged 70 commits into
dotnet:main
from
ijklam:access-modifies-to-auto-properties
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/Tangent-90/fsharp into access-modifies-to-auto-properties
…om/Tangent-90/fsharp into access-modifies-to-auto-properties
❗ Release notes required
|
Thanks for addressing this. I think HashDirectives tests need update also. |
That's weird, I swear I've fixed it. Must've been something else which was merged in between. |
Thanks for staying on top of it, sorry it was taking that long to get it in. |
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete unfinished change of #16861
Change the conflicted error number of
Access-modifies-to-auto-properties