Disallow calling abstract methods directly on interfaces #17021

edgarfgp · 2024-04-10T18:34:31Z

Description

Check introduced to ensure we can call on virtual members, can't call abstracts.

open System.Numerics
IAdditionOperators.op_Addition (3, 6) // System.BadImageFormatException: Bad IL format.

IAdditionOperators.op_CheckedAddition (3, 6) // Compiles and run as this a static virtual

See:
https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Numerics/IAdditionOperators.cs,5b77e6b404819054

Before

System.BadImageFormatException: Bad IL format.

After

(Error 3866, Line 15, Col 82, Line 15, Col 129, "A static abstract interface member can be accessed only on a type parameter.")

Rationale:

Added an specific error message to make it clear that is not allowed calling static abstract members on an interface.

Checklist

Test cases added
Release notes entry updated:

github-actions · 2024-04-10T18:41:27Z

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description

src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

src/Compiler/Checking/ConstraintSolver.fs

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>

src/Compiler/Checking/ConstraintSolver.fs

...piler.ComponentTests/Conformance/Types/TypeConstraints/IWSAMsAndSRTPs/IWSAMsAndSRTPsTests.fs

edgarfgp · 2024-04-15T13:09:43Z

This is ready :)

docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>

docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>

edgarfgp · 2024-04-16T06:28:30Z

PR to update the IWASM design notes fsharp/fslang-design#767

src/Compiler/FSComp.txt

edgarfgp · 2024-04-16T10:52:53Z

##[error]The job running on agent Azure Pipelines 68 ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

psfinaki

Great stuff @edgarfgp and thanks @brianrourkeboll for the thorough review and suggestions.

edgarfgp · 2024-04-16T14:13:56Z

One less internal error :). Lets go to the next one

…7053) * Disallow calling abstract methods directly on interfaces * More tests * IWSAMs are not supported by NET472 * Update src/Compiler/Checking/ConstraintSolver.fs * fix typos * looking for the right check * Add comments * move release notes * Add a new error number and message * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md * Improve error message --------- Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>

* Disallow calling abstract methods directly on interfaces (#17021) * Disallow calling abstract methods directly on interfaces * More tests * IWSAMs are not supported by NET472 * Update src/Compiler/Checking/ConstraintSolver.fs Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * fix typos * looking for the right check * Add comments * move release notes * Add a new error number and message * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Improve error message --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Always use `typeEquivAux EraseMeasures` (for integral range optimizations) (#17048) * Always use `typeEquivAux EraseMeasures` * Update release notes * Update baselines --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> --------- Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

* Disallow calling abstract methods directly on interfaces (#17021) * Disallow calling abstract methods directly on interfaces * More tests * IWSAMs are not supported by NET472 * Update src/Compiler/Checking/ConstraintSolver.fs Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * fix typos * looking for the right check * Add comments * move release notes * Add a new error number and message * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Improve error message --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Always use `typeEquivAux EraseMeasures` (for integral range optimizations) (#17048) * Always use `typeEquivAux EraseMeasures` * Update release notes * Update baselines --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> --------- Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

* Disallow calling abstract methods directly on interfaces (#17021) * Disallow calling abstract methods directly on interfaces * More tests * IWSAMs are not supported by NET472 * Update src/Compiler/Checking/ConstraintSolver.fs Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * fix typos * looking for the right check * Add comments * move release notes * Add a new error number and message * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Improve error message --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Always use `typeEquivAux EraseMeasures` (for integral range optimizations) (#17048) * Always use `typeEquivAux EraseMeasures` * Update release notes * Update baselines --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> * Error message that explicitly disallowed static abstract members in classes. (#17055) * WIP * Error message that explicitly disallowed static abstract methods in abstract classes * release notes * SynTypeDefnKind.Class * Fix #16761 (#17047) * Fix #16761 * Fully async version + ignore cancellation on external navigation * Automated command ran: fantomas Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

Disallow calling abstract methods directly on interfaces

79df557

edgarfgp mentioned this pull request Apr 10, 2024

Disallow calling abstract methods directly on interfaces #16319

Closed

edgarfgp marked this pull request as ready for review April 10, 2024 19:21

edgarfgp requested a review from a team as a code owner April 10, 2024 19:21

T-Gro reviewed Apr 11, 2024

View reviewed changes

src/Compiler/Checking/ConstraintSolver.fs Outdated Show resolved Hide resolved

edgarfgp and others added 4 commits April 11, 2024 14:38

Merge branch 'main' into fix-14012

d8bbd0f

More tests

d8d9062

IWSAMs are not supported by NET472

b542709

Update src/Compiler/Checking/ConstraintSolver.fs

7fa7b8f

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>

psfinaki reviewed Apr 12, 2024

View reviewed changes

src/Compiler/Checking/ConstraintSolver.fs Outdated Show resolved Hide resolved

psfinaki reviewed Apr 12, 2024

View reviewed changes

src/Compiler/Checking/ConstraintSolver.fs Outdated Show resolved Hide resolved

fix typos

7fa370b

edgarfgp force-pushed the fix-14012 branch from 78919cf to 7fa370b Compare April 12, 2024 20:49

edgarfgp added 5 commits April 14, 2024 21:40

looking for the right check

ce7acc2

Merge branch 'main' into fix-14012

9ecd812

Add comments

1fc2c73

Merge branch 'main' into fix-14012

cccb6c7

move release notes

f1310d5

brianrourkeboll reviewed Apr 15, 2024

View reviewed changes

...piler.ComponentTests/Conformance/Types/TypeConstraints/IWSAMsAndSRTPs/IWSAMsAndSRTPsTests.fs Outdated Show resolved Hide resolved

Add a new error number and message

604ba02

brianrourkeboll approved these changes Apr 15, 2024

View reviewed changes

Merge branch 'main' into fix-14012

888382b

brianrourkeboll reviewed Apr 15, 2024

View reviewed changes

docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Outdated Show resolved Hide resolved

Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

df5d20e

Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>

brianrourkeboll reviewed Apr 15, 2024

View reviewed changes

docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Outdated Show resolved Hide resolved

Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

5154ae8

Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>

vzarytovskii reviewed Apr 16, 2024

View reviewed changes

src/Compiler/FSComp.txt Outdated Show resolved Hide resolved

edgarfgp and others added 2 commits April 16, 2024 10:18

Merge branch 'main' into fix-14012

fe85336

Improve error message

968fe31

edgarfgp force-pushed the fix-14012 branch from 0d73632 to 968fe31 Compare April 16, 2024 09:22

vzarytovskii approved these changes Apr 16, 2024

View reviewed changes

edgarfgp closed this Apr 16, 2024

edgarfgp reopened this Apr 16, 2024

psfinaki approved these changes Apr 16, 2024

View reviewed changes

psfinaki merged commit f6ae54b into dotnet:main Apr 16, 2024
34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow calling abstract methods directly on interfaces #17021

Disallow calling abstract methods directly on interfaces #17021

edgarfgp commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading

edgarfgp commented Apr 15, 2024

edgarfgp commented Apr 16, 2024

edgarfgp commented Apr 16, 2024

psfinaki left a comment

edgarfgp commented Apr 16, 2024

Disallow calling abstract methods directly on interfaces #17021

Disallow calling abstract methods directly on interfaces #17021

Conversation

edgarfgp commented Apr 10, 2024 • edited Loading

Description

Before

After

Rationale:

Checklist

github-actions bot commented Apr 10, 2024 • edited Loading

❗ Release notes required

edgarfgp commented Apr 15, 2024

edgarfgp commented Apr 16, 2024

edgarfgp commented Apr 16, 2024

psfinaki left a comment

Choose a reason for hiding this comment

edgarfgp commented Apr 16, 2024

edgarfgp commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Apr 10, 2024 •

edited

Loading