Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default GraphBasedChecking, ParallelOptimization and ParallelIlxGen optimizations #17400

Closed
wants to merge 9 commits into from
Closed

Default GraphBasedChecking, ParallelOptimization and ParallelIlxGen optimizations #17400

wants to merge 9 commits into from

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jul 10, 2024 •
edited
Loading

Description

Enable by default:

  • GraphBasedChecking
  • ParallelOptimization
  • ParallelIlxGen

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@edgarfgp edgarfgp force-pushed the enable-some-more-optimizations branch from 1168eba to 6d0168e Compare July 10, 2024 09:51
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Jul 10, 2024 •
edited
Loading

@vzarytovskii @KevinRansom. I would like to propose enabling the described optimizations by default. I'm using Kevin's
Defaultrealsig PR as an example. Let me know your thoughts and any pointer is appreciated.

@vzarytovskii
Copy link
Member

Could you please mention in FCS changelog that we changed the defaults?

@edgarfgp
Copy link
Contributor Author

Could you please mention in FCS changelog that we changed the defaults?

Done. Not sure why the bot decided to put the No release notes required

@edgarfgp edgarfgp force-pushed the enable-some-more-optimizations branch from 6d53f40 to b09c82b Compare July 11, 2024 05:45
vzarytovskii
vzarytovskii reviewed Jul 12, 2024
View reviewed changes
...ComponentTests/EmittedIL/Inlining/Match01_RealInternalSignatureOff.fs.il.netcore.release.bsl
@@ -1107,6 +1099,42 @@
}
}

.method public static int32 select1(class Match01/Test1 x) cil managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't look good, that it changed ordering. A potential determinism issue here

...Sharp.Compiler.ComponentTests/EmittedIL/TestFunctions/TestFunction17.fs.il.netcore.debug.bsl
@@ -124,18 +116,12 @@
int32 V_3,
class [runtime]System.Collections.IComparer V_4,
int32 V_5,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also doesn't look good, unsure why baselines changed, ilx output should retain the same order

@edgarfgp edgarfgp closed this Jul 15, 2024
@edgarfgp edgarfgp mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf left review comments

@vzarytovskii vzarytovskii vzarytovskii left review comments

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarfgp @vzarytovskii @nojaf