Turn a bunch of options by default #17442

vzarytovskii · 2024-07-24T13:08:47Z

Attempt to enable some parallel options (graph checking, ilxgen, resolution) by default.

Firstly, based on local tests, parallel ilxgen causes a bunch of baselines to change. This either caused by sorting before emitting/generating, which is fine. Or it's caused by trully parallel generation, which will break determinism.

Secondly, graph checking causes some things in tests to be not found during test (i'd wait for CI, to see exact issue).

I am very hesitant to enable graph checking by default, since it might cause typechecker just to fail in places it wasn't before, there might be (and probably will be) a bunch of cases where it will surface. What we can do is to have an msbuild property which will allow people to test it on more projects (or ask them to use --test: flag).

Regarding the ilxgen - we need a proof that codegen order is expected. If it's not, it has to be fixed, or always been disabled for the determinism.

I didn't find any anomalies in both ParallelReferenceResolution and OptimizationProcessingMode.Parallel yet.

github-actions · 2024-07-24T13:09:34Z

✅ No release notes required

edgarfgp · 2024-07-24T13:14:15Z

Thanks @vzarytovskii for looking into this. I failed in my attempt in #17400

vzarytovskii · 2024-07-24T14:20:18Z

A bunch of tests currently failing:

Some fsi tests are failing because of locked dlls (I presume it's because parallel resolution)
Some resolution tests are failing (it's either resolution or graph checking):

test3.fsx(109,106): error FS0001: The type 'TheGeneratedType5' is not compatible with the type 'Test2a.PublicGenerativeTypes.TheGeneratedType5'

A test for same type in the different references is failing (due to either parallel resolution, or graph checking).

I will turn parallel resolution off and see what still fails.

vzarytovskii · 2024-07-24T15:19:31Z

Majority of issues were due to parallel resolution it seems. Still doesn't explain why do I have weird issues in tests locally, but not in CI.

It's good. I will leave parallel ilxgen and resolution off, and graph type checking and optimization on, and leave it up to @KevinRansom and @T-Gro to decide whether we want them on by default. The latter should be fine, the former - we didn't test on many solutions (maybe 3-5 in the wild), so there's always a risk of things going wrong. There's now an opt-out mechanism though.

T-Gro · 2024-07-26T11:49:13Z

Majority of issues were due to parallel resolution it seems. Still doesn't explain why do I have weird issues in tests locally, but not in CI.

It's good. I will leave parallel ilxgen and resolution off, and graph type checking and optimization on, and leave it up to @KevinRansom and @T-Gro to decide whether we want them on by default. The latter should be fine, the former - we didn't test on many solutions (maybe 3-5 in the wild), so there's always a risk of things going wrong. There's now an opt-out mechanism though.

This exists already:
parallelIlxGenEnabled = tcConfig.parallelIlxGen && not tcConfig.deterministic

i.e. deterministic builds should not be affected.

vzarytovskii · 2024-08-12T18:48:03Z

This is ready, apart from some output tests which will likely be failing. @nojaf @edgarfgp @dawedawe does this make sense to enable those options now, and the rest later? I need to investigate those a bit more. With these though, we will be having an opt-out at least.

…sharp into parallels-default

vzarytovskii · 2024-08-12T20:02:39Z

@T-Gro @KevinRansom @abonie @psfinaki I need a sanity check on it. Also, a sign-off.

…sharp into parallels-default

nojaf

Looks good, thanks for the follow-up.
I think it makes sense to include this for previews and release candidates.
This gives us enough time to reconsider the defaults before November if needed.

Directory.Build.props

docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

vzarytovskii · 2024-08-16T14:55:20Z

So, two things broke when turning this on by default

First looks like graph checking in topinit test:

fsharp/tests/fsharp/tests.fs

Line 1488 in c9bed79

    
           fsc cfg "%s --realsig- --optimize -o both69514.exe -g" cfg.fsc_flags ["lib69514.fs"; "app69514.fs"]

fsharp/tests/fsharp/core/topinit/app69514.fs

Lines 1 to 5 in c9bed79

    
           module X 
        
           let v = global.Lib.File1.discState.Second 
        
           let v2 = global.Lib.File2.discState.Rep

fsharp/tests/fsharp/core/topinit/lib69514.fs

Lines 1 to 13 in c9bed79

    
           namespace Lib 
        
           module File1 = 
        
               let mutable discState = System.DateTime.Now 
        
           module File2 = 
        
               [<Struct>] 
        
               type DiscState(rep : int) = 
        
                   member this.Rep = rep 
        
               let mutable discState = DiscState(0)

Fails with:

app69514.fs(3,16): error FS0039: The value, namespace, type or module 'Lib' is not defined.


app69514.fs(5,17): error FS0039: The value, namespace, type or module 'Lib' is not defined.

Not entirely sure yet, but also related to types resolution in diamondAssembly type provider test:

fsharp/tests/fsharp/TypeProviderTests.fs

Lines 39 to 41 in c9bed79

    
           [<Test>] 
        
           let diamondAssembly () = 
        
               let cfg = testConfig "typeProviders/diamondAssembly"

test3.fsx(96,70): error FS0001: The type 'Test2a.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(96,105): error FS0001: The type 'Test2a.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(97,70): error FS0001: The type 'Test2a.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(98,70): error FS0001: The type 'Test2a.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(98,105): error FS0001: The type 'Test2b.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(99,70): error FS0001: The type 'Test2a.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(101,70): error FS0001: The type 'Test2b.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(101,105): error FS0001: The type 'Test2a.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(102,70): error FS0001: The type 'Test2b.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(103,70): error FS0001: The type 'Test2b.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(103,105): error FS0001: The type 'Test2b.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(104,70): error FS0001: The type 'Test2b.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test1.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(107,106): error FS0001: The type 'Test1.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test2a.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(109,106): error FS0001: The type 'TheGeneratedType5' is not compatible with the type 'Test2a.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(112,106): error FS0001: The type 'Test1.PublicGenerativeTypes.TheGeneratedType5' is not compatible with the type 'Test2a.PublicGenerativeTypes.TheGeneratedType5'


test3.fsx(114,106): error FS0001: The type 'TheGeneratedType5' is not compatible with the type 'Test2a.PublicGenerativeTypes.TheGeneratedType5'

Results:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=778074&view=ms.vss-test-web.build-test-results-tab&runId=19935626&resultId=100551&paneView=debug

@nojaf any pointers what to look at in this case?

nojaf · 2024-08-16T15:00:25Z

@vzarytovskii , I'm gonna teach you a little trick, add the scenario to

fsharp/tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/Scenarios.fs

Line 39 in c9bed79

let internal codebases =

and then run

fsharp/tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/CompilationTests.fs

Lines 49 to 55 in c9bed79

    
           [<TestCaseSource(nameof scenarios)>] 
        
           let ``Compile a valid scenario using graph-based type-checking`` (scenario: Scenario) = 
        
               compileAValidScenario scenario Method.Graph 
        
           [<TestCaseSource(nameof scenarios)>] 
        
           let ``Compile a valid scenario using sequential type-checking`` (scenario: Scenario) = 
        
               compileAValidScenario scenario Method.Sequential

if sequential passes and graph doesn't then it is indeed a graph problem.

I need to go now, but I can look into this on Monday.
Initial gut feeling is that we need to strip \global`` in:

SynLongIdent.SynLongIdent(
                                                id = [
                                                    Ident("`global`", R("(2,9--2,15)"))
                                                    Ident("Lib", R("(2,16--2,19)"))
                                                    Ident("File1", R("(2,20--2,25)"))
                                                    Ident("discState", R("(2,26--2,35)"))
                                                    Ident("Second", R("(2,36--2,42)"))
                                                ],
                                                dotRanges = [ R("(2,15--2,16)"); R("(2,19--2,20)"); R("(2,25--2,26)"); R("(2,35--2,36)") ],
                                                trivia = [ Some(IdentTrivia.OriginalNotation("global")); None; None; None; None ]
                                            ),

vzarytovskii · 2024-08-16T15:01:49Z

Initial gut feeling is that we need to strip \global`` in:

This what I initially noticed in the test. Let me try and tinker with it.

vzarytovskii · 2024-08-16T17:22:51Z

Added test here: #17553, will look at fixing it (need to learn a bit more about how graph checking works).

nojaf · 2024-09-13T07:58:42Z

Hi @vzarytovskii is the plan still to have this for November?

vzarytovskii · 2024-09-13T08:59:29Z

Hi @vzarytovskii is the plan still to have this for November?

I will try to wrap it, but it might have to do in the following release. Too many issues with this release and didn't have time to finish this one :(

nojaf · 2024-09-13T09:31:52Z

following release

Would that be minor or major?

vzarytovskii · 2024-09-13T09:48:54Z

following release

Would that be minor or major?

Minor, as soon as sdk freeze is lifted

vzarytovskii · 2024-09-13T12:28:45Z

Ok, probably not going to make it till EOD, there are some fixes need to be made to the graph checking, will look at those:

+++ Conformance\ImplementationFilesAndSignatureFiles\CheckingOfImplementationFiles (E-SignatureAfterSource) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc    E-SignatureAfterSource.fs E-SignatureAfterSource.fsi 
Exit code: 1
Error:     2
Microsoft (R) F# Compiler version 12.9.100.0 for F# 9.0
Copyright (c) Microsoft Corporation. All Rights Reserved.
(4,8): error FS0248: Two modules named 'E-SignatureAfterSource' occur in two parts of this assembly
(8,1): warning FS0221: The declarations in this file will be placed in an implicit module 'E-SignatureAfterSource' based on the file name 'E-SignatureAfterSource.fsi'. However this is not a valid F# identifier, so the contents will not be accessible from other files. Consider renaming the file or adding a 'module' or 'namespace' declaration at the top of the file.
--------------------------------------------------------
Microsoft (R) F# Compiler version 12.9.100.0 for F# 9.0
Copyright (c) Microsoft Corporation. All Rights Reserved.
(4,8): error FS0248: Two modules named 'E-SignatureAfterSource' occur in two parts of this assembly
(8,1): warning FS0221: The declarations in this file will be placed in an implicit module 'E-SignatureAfterSource' based on the file name 'E-SignatureAfterSource.fsi'. However this is not a valid F# identifier, so the contents will not be accessible from other files. Consider renaming the file or adding a 'module' or 'namespace' declaration at the top of the file.

*** The following necessary lines were never matched:
***	\(8,1\):.+error FS0238:.+An implementation of file or module 'E-SignatureAfterSource' has already been given\. Compilation order is significant in F# because of type inference\. You may need to adjust the order of your files to place the signature file before the implementation\. In Visual Studio files are type-checked in the order they appear in the project file, which can be edited manually or adjusted using the solution explorer

+++ InteractiveSession\Misc (VerbatimIdentifier01.fsx) +++
Compiling: [fsiAnyCPU<VerbatimIdentifier01.fsx   --nologo ]
Quantifier follows nothing in regex; marked by <-- HERE in m/val ``(+ <-- HERE )`` : bool = true/ at D:\a\_work\1\s\tests\fsharpqa\source\run.pl line 212.
+++ InteractiveSession\Misc (RelativeHashRResolution01_fsc) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ccc\RelativeHashRResolution01_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ccc\RelativeHashRResolution01_1.fsx ]

ccc\RelativeHashRResolution01_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution02_fsc) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ccc\RelativeHashRResolution02_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ccc\RelativeHashRResolution02_1.fsx ]

ccc\RelativeHashRResolution02_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution03_fsc) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ccc\RelativeHashRResolution03_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ccc\RelativeHashRResolution03_1.fsx ]

ccc\RelativeHashRResolution03_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution04_fsc) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo aaa\bbb\RelativeHashRResolution04_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo aaa\bbb\RelativeHashRResolution04_1.fsx ]

aaa\bbb\RelativeHashRResolution04_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution05_fsc) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo aaa\bbb\RelativeHashRResolution05_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo aaa\bbb\RelativeHashRResolution05_1.fsx ]

aaa\bbb\RelativeHashRResolution05_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution01_fscrelative) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ..\Misc\ccc\RelativeHashRResolution01_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ..\Misc\ccc\RelativeHashRResolution01_1.fsx ]

ccc\RelativeHashRResolution01_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution02_fscrelative) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ..\Misc\ccc\RelativeHashRResolution02_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ..\Misc\ccc\RelativeHashRResolution02_1.fsx ]

ccc\RelativeHashRResolution02_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution03_fscrelative) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ..\Misc\ccc\RelativeHashRResolution03_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ..\Misc\ccc\RelativeHashRResolution03_1.fsx ]

ccc\RelativeHashRResolution03_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution04_fscrelative) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ..\Misc\aaa\bbb\RelativeHashRResolution04_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ..\Misc\aaa\bbb\RelativeHashRResolution04_1.fsx ]

aaa\bbb\RelativeHashRResolution04_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution05_fscrelative) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo ..\Misc\aaa\bbb\RelativeHashRResolution05_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo ..\Misc\aaa\bbb\RelativeHashRResolution05_1.fsx ]

aaa\bbb\RelativeHashRResolution05_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution01_fscsimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ccc\RelativeHashRResolution01_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ccc\RelativeHashRResolution01_1.fsx ]

ccc\RelativeHashRResolution01_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution02_fscsimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ccc\RelativeHashRResolution02_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ccc\RelativeHashRResolution02_1.fsx ]

ccc\RelativeHashRResolution02_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution03_fscsimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ccc\RelativeHashRResolution03_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ccc\RelativeHashRResolution03_1.fsx ]

ccc\RelativeHashRResolution03_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution04_fscsimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" aaa\bbb\RelativeHashRResolution04_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" aaa\bbb\RelativeHashRResolution04_1.fsx ]

aaa\bbb\RelativeHashRResolution04_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution05_fscsimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" aaa\bbb\RelativeHashRResolution05_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" aaa\bbb\RelativeHashRResolution05_1.fsx ]

aaa\bbb\RelativeHashRResolution05_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution01_fscrelativesimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\ccc\RelativeHashRResolution01_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\ccc\RelativeHashRResolution01_1.fsx ]

ccc\RelativeHashRResolution01_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution01_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution02_fscrelativesimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\ccc\RelativeHashRResolution02_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\ccc\RelativeHashRResolution02_1.fsx ]

ccc\RelativeHashRResolution02_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution02_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution03_fscrelativesimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\ccc\RelativeHashRResolution03_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\ccc\RelativeHashRResolution03_1.fsx ]

ccc\RelativeHashRResolution03_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution03_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution04_fscrelativesimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\aaa\bbb\RelativeHashRResolution04_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\aaa\bbb\RelativeHashRResolution04_1.fsx ]

aaa\bbb\RelativeHashRResolution04_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution04_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL
+++ InteractiveSession\Misc (RelativeHashRResolution05_fscrelativesimple) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\aaa\bbb\RelativeHashRResolution05_1.fsx 
Exit code: 1
Error:     0
(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
--------------------------------------------------------
Compiling: [fsc   --nologo --simpleresolution --noframework -r:"D:\a\_work\1\s\artifacts\bin\fsc\Release\net472\FSharp.Core.dll" ..\Misc\aaa\bbb\RelativeHashRResolution05_1.fsx ]

aaa\bbb\RelativeHashRResolution05_1.fsx(8,14): error FS0039: The value, namespace, type or module 'RelativeHashRResolution05_2' is not defined.
Compile Unexpectedly Failed: 256 
FAIL

nojaf · 2024-09-13T12:42:20Z

What tests are you running there? Is that only using graph-based checking or all settings?

vzarytovskii · 2024-09-13T12:44:39Z

What tests are you running there? Is that only using graph-based checking or all settings?

Those are fsharpqa tests, RelativeHashRResolution01_1.fsx (and others from log, there are a few files there, mostly I see fsx files), it's all settings which are on by default now - graph checking and parallel optimizations.

Seems like many of them are related to relative # resolution ("#I/#r" I presume?).

nojaf · 2024-09-13T12:58:34Z

Could you try and just run it with graph checking. I'm wondering if that really is the culprit.

vzarytovskii · 2024-09-13T13:03:13Z

Could you try and just run it with graph checking. I'm wondering if that really is the culprit.

Will try it, but it's unlikely an optimizer, since the issues are during checking and resolution. Optimizer ones would've popped up at a later phase. Also i think that by default fsharpqa is compiling debug/without optimizations. I will double check it though.

vzarytovskii · 2024-11-01T17:01:47Z

Superseded by #17948

majocha · 2024-11-01T18:23:32Z

Maybe it's nothing but it caught my eye, so I'll put it here before I forget:
This cancels immediately:

fsharp/src/Compiler/Driver/GraphChecking/GraphProcessing.fs

Lines 113 to 115 in 658b245

    
           let incrementProcessedNodesCount () = 
        
               if processedCount.Increment() = nodes.Count then 
        
                   localCts.Cancel()

to signal things are done IIUC.

But it is called here:

fsharp/src/Compiler/Driver/GraphChecking/GraphProcessing.fs

Lines 146 to 147 in 658b245

    
           unblockedDependents |> Array.iter queueNode 
        
           incrementProcessedNodesCount ()

after queueNode started some work with Async.Start:

fsharp/src/Compiler/Driver/GraphChecking/GraphProcessing.fs

Lines 117 to 118 in 658b245

    
           let rec queueNode node = 
        
               Async.Start(

I wonder if maybe some things are not really done when the cancellation happens?

Turn a bunch of options by default

58de9b0

Update xlf

b864ea2

Disable parallel resolution

76b0fa5

vzarytovskii added 2 commits August 12, 2024 20:18

Fomatting + turn options for compiler on by default

24e5b8b

Merge branch 'main' into parallels-default

0f8b275

vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 12, 2024

vzarytovskii added 2 commits August 12, 2024 21:00

Cleanup + release notes

3dda157

Merge branch 'parallels-default' of https://github.com/vzarytovskii/f…

3790e99

…sharp into parallels-default

vzarytovskii closed this Aug 12, 2024

vzarytovskii reopened this Aug 12, 2024

Baselines

c709f89

vzarytovskii removed the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 12, 2024

Update 9.0.100.md

dd99ddf

vzarytovskii added 2 commits August 12, 2024 22:47

Some additional baselines cleanup, perhaps, pretty please?

4d64230

Merge branch 'parallels-default' of https://github.com/vzarytovskii/f…

0ef033e

…sharp into parallels-default

nojaf approved these changes Aug 13, 2024

View reviewed changes

Directory.Build.props Show resolved Hide resolved

vzarytovskii added 3 commits August 13, 2024 11:15

Baselines, please

1e028ec

Maybe fix baselines?

8bf9b33

Merge branch 'main' into parallels-default

489cef0

psfinaki reviewed Aug 13, 2024

View reviewed changes

docs/release-notes/.FSharp.Compiler.Service/9.0.100.md Outdated Show resolved Hide resolved

vzarytovskii added 2 commits August 14, 2024 20:28

Fixed more baselines

494a95c

Merge branch 'main' into parallels-default

8049654

vzarytovskii marked this pull request as ready for review August 14, 2024 18:30

vzarytovskii requested a review from a team as a code owner August 14, 2024 18:30

Merge branch 'main' into parallels-default

0057fa7

T-Gro approved these changes Aug 16, 2024

View reviewed changes

vzarytovskii mentioned this pull request Aug 16, 2024

Graph typechecking issue fix when using global namespace. #17553

Merged

Merge branch 'main' into parallels-default

3b46f0f

Merge branch 'main' into parallels-default

8ebb754

edgarfgp mentioned this pull request Oct 24, 2024

Reuse typechecking results - stage 1 #17898

Open

vzarytovskii mentioned this pull request Nov 1, 2024

Enable parallel compilation features for users of LangVersion=preview #17948

Merged

vzarytovskii closed this Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn a bunch of options by default #17442

Turn a bunch of options by default #17442

vzarytovskii commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

edgarfgp commented Jul 24, 2024

vzarytovskii commented Jul 24, 2024

vzarytovskii commented Jul 24, 2024 •

edited

Loading

T-Gro commented Jul 26, 2024

vzarytovskii commented Aug 12, 2024

vzarytovskii commented Aug 12, 2024

nojaf left a comment

vzarytovskii commented Aug 16, 2024

nojaf commented Aug 16, 2024

vzarytovskii commented Aug 16, 2024

vzarytovskii commented Aug 16, 2024 •

edited

Loading

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024 •

edited

Loading

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024 •

edited

Loading

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024

vzarytovskii commented Nov 1, 2024 •

edited

Loading

majocha commented Nov 1, 2024

Turn a bunch of options by default #17442

Turn a bunch of options by default #17442

Conversation

vzarytovskii commented Jul 24, 2024 • edited Loading

github-actions bot commented Jul 24, 2024 • edited Loading

✅ No release notes required

edgarfgp commented Jul 24, 2024

vzarytovskii commented Jul 24, 2024

vzarytovskii commented Jul 24, 2024 • edited Loading

T-Gro commented Jul 26, 2024

vzarytovskii commented Aug 12, 2024

vzarytovskii commented Aug 12, 2024

nojaf left a comment

Choose a reason for hiding this comment

vzarytovskii commented Aug 16, 2024

nojaf commented Aug 16, 2024

vzarytovskii commented Aug 16, 2024

vzarytovskii commented Aug 16, 2024 • edited Loading

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024 • edited Loading

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024 • edited Loading

nojaf commented Sep 13, 2024

vzarytovskii commented Sep 13, 2024

vzarytovskii commented Nov 1, 2024 • edited Loading

majocha commented Nov 1, 2024

vzarytovskii commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

vzarytovskii commented Jul 24, 2024 •

edited

Loading

vzarytovskii commented Aug 16, 2024 •

edited

Loading

vzarytovskii commented Sep 13, 2024 •

edited

Loading

vzarytovskii commented Sep 13, 2024 •

edited

Loading

vzarytovskii commented Nov 1, 2024 •

edited

Loading