Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable parallel compilation features for users of LangVersion=preview #17948

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Enable parallel compilation features for users of LangVersion=preview #17948

merged 6 commits into from
Nov 6, 2024

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Nov 1, 2024

Description

  • Makes an accessible project switch for [+|-] parallel compilation features together (graph checking, optimisation, ilxgen)
  • Keeps the isolated switches to selectively change either of them
  • Turns it on by default for projects opting in LangVersion=preview.
    • This is also for a preview version of the product. This is an attempt to do selective application before rolling it out to everyone

Expectation is to turn it on by default for all projects after a stabilization period.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

vzarytovskii

This comment was marked as outdated.

Sign in to view

@T-Gro T-Gro dismissed vzarytovskii’s stale review November 1, 2024 16:59

The linked PR has CI issues which need effort to address. Selective enablement can be done earlier.

@T-Gro T-Gro requested a review from vzarytovskii November 1, 2024 16:59
@vzarytovskii vzarytovskii mentioned this pull request Nov 1, 2024
Closed
@T-Gro T-Gro marked this pull request as ready for review November 1, 2024 17:58
@T-Gro T-Gro requested a review from a team as a code owner November 1, 2024 17:58
edgarfgp
edgarfgp approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@edgarfgp edgarfgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@T-Gro T-Gro enabled auto-merge (squash) November 6, 2024 18:02
@T-Gro T-Gro merged commit 26edc07 into main Nov 6, 2024
32 checks passed
@T-Gro T-Gro deleted the enable-parallel-features-for-preview-users branch November 11, 2024 10:57
@dotnet-bot dotnet-bot mentioned this pull request Nov 30, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@T-Gro @vzarytovskii @psfinaki @edgarfgp