Turn a bunch of options by default

Directory.Build.props

@@ -41,6 +41,11 @@
     <EnablePublishReadyToRun Condition="'$(SourceBuildUseMonoRuntime)' == 'true'">false</EnablePublishReadyToRun>
   </PropertyGroup>
 
+  <!-- Set parallel options on by default for compiler. Once compiler with new options is shipped, they need to be used -->
+  <PropertyGroup>
+    <OtherFlags>$(OtherFlags) --test:ParallelOptimization --test:GraphBasedChecking</OtherFlags>
+  </PropertyGroup>
+
   <Import Project="$(RepoRoot)/Directory.Build.props.user" Condition="Exists('$(RepoRoot)/Directory.Build.props.user')" />
 
   <PropertyGroup Condition="'$(BUILDING_USING_DOTNET)' == 'true'">

docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@@ -31,5 +31,7 @@
 * Applied nullable reference types to FSharp.Compiler.Service itself ([PR #15310](https://github.com/dotnet/fsharp/pull/15310))
 * Ensure that isinteractive multi-emit backing fields are not public. ([Issue #17439](https://github.com/dotnet/fsharp/issues/17438)), ([PR #17439](https://github.com/dotnet/fsharp/pull/17439))
 * Enable FSharp 9.0 Language Version ([Issue #17497](https://github.com/dotnet/fsharp/issues/17438)), [PR](https://github.com/dotnet/fsharp/pull/17500)))
+* Enable graph type checking and parallel optimizations by default, can be turned off via the following compiler flags `--graphtypechecking-` and `--paralleloptimization-` respectivelly. ([PR #17442](https://github.com/dotnet/fsharp/pull/17442))
+* Added flags for enabling parallel ILx generation and parallel reference resolution, to enable, turn on the following compiler flags: `--parallelilxgen+` and `--parallelreferenceresolution+` ([PR #17442](https://github.com/dotnet/fsharp/pull/17442))
 * Better error reporting for unions with duplicated fields. ([PR #17521](https://github.com/dotnet/fsharp/pull/17521))
 ### Breaking Changes

src/Compiler/Driver/CompilerConfig.fs

@@ -766,18 +766,11 @@ type TcConfigBuilder =
             doTLR = false
             doFinalSimplify = false
             optsOn = false
-            optSettings =
-                { OptimizationSettings.Defaults with
-                    processingMode =
-                        if FSharpExperimentalFeaturesEnabledAutomatically then
-                            OptimizationProcessingMode.Parallel
-                        else
-                            OptimizationProcessingMode.Sequential
-                }
+            optSettings = OptimizationSettings.Defaults
             emitTailcalls = true
             deterministic = false
             concurrentBuild = true
-            parallelIlxGen = FSharpExperimentalFeaturesEnabledAutomatically
+            parallelIlxGen = false
             emitMetadataAssembly = MetadataAssemblyGeneration.None
             preferredUiLang = None
             lcid = None
@@ -823,11 +816,7 @@ type TcConfigBuilder =
             captureIdentifiersWhenParsing = false
             typeCheckingConfig =
                 {
-                    TypeCheckingConfig.Mode =
-                        if FSharpExperimentalFeaturesEnabledAutomatically then
-                            TypeCheckingMode.Graph
-                        else
-                            TypeCheckingMode.Sequential
+                    TypeCheckingConfig.Mode = TypeCheckingMode.Graph
                     DumpGraph = false
                 }
             dumpSignatureData = false

src/Compiler/Driver/CompilerOptions.fs

@@ -571,6 +571,41 @@ let SetDeterministicSwitch (tcConfigB: TcConfigBuilder) switch =
 let SetRealsig (tcConfigB: TcConfigBuilder) switch =
     tcConfigB.realsig <- (switch = OptionSwitch.On)
 
+let SetGraphTypeCheckingSwitch (tcConfigB: TcConfigBuilder) switch =
+    match switch with
+    | OptionSwitch.On ->
+        tcConfigB.typeCheckingConfig <-
+            { tcConfigB.typeCheckingConfig with
+                TypeCheckingConfig.Mode = TypeCheckingMode.Graph
+            }
+
+    | OptionSwitch.Off ->
+        tcConfigB.typeCheckingConfig <-
+            { tcConfigB.typeCheckingConfig with
+                TypeCheckingConfig.Mode = TypeCheckingMode.Sequential
+            }
+
+let SetParallelOptimizationSwitch (tcConfigB: TcConfigBuilder) switch =
+    match switch with
+    | OptionSwitch.On ->
+        tcConfigB.optSettings <-
+            { tcConfigB.optSettings with
+                processingMode = OptimizationProcessingMode.Parallel
+            }
+    | OptionSwitch.Off ->
+        tcConfigB.optSettings <-
+            { tcConfigB.optSettings with
+                processingMode = OptimizationProcessingMode.Sequential
+            }
+
+let SetParallelIlxGenSwitch (tcConfigB: TcConfigBuilder) switch =
+    tcConfigB.parallelIlxGen <- (switch = OptionSwitch.On)
+
+let SetPparallelReferenceResolutionSwitch (tcConfigB: TcConfigBuilder) switch =
+    match switch with
+    | OptionSwitch.On -> tcConfigB.parallelReferenceResolution <- ParallelReferenceResolution.On
+    | OptionSwitch.Off -> tcConfigB.parallelReferenceResolution <- ParallelReferenceResolution.Off
+
 let SetReferenceAssemblyOnlySwitch (tcConfigB: TcConfigBuilder) switch =
     match tcConfigB.emitMetadataAssembly with
     | MetadataAssemblyGeneration.None when (not tcConfigB.standalone) && tcConfigB.extraStaticLinkRoots.IsEmpty ->
@@ -1056,6 +1091,38 @@ let codeGenerationFlags isFsi (tcConfigB: TcConfigBuilder) =
                 None,
                 Some(FSComp.SR.optsReflectionFree ())
             )
+
+            CompilerOption(
+                "graphtypechecking",
+                tagNone,
+                OptionSwitch(SetGraphTypeCheckingSwitch tcConfigB),
+                None,
+                Some(FSComp.SR.optsGraphTypeChecking ())
+            )
+
+            CompilerOption(
+                "paralleloptimization",
+                tagNone,
+                OptionSwitch(SetParallelOptimizationSwitch tcConfigB),
+                None,
+                Some(FSComp.SR.optsParallelOptimization ())
+            )
+
+            CompilerOption(
+                "parallelilxgen",
+                tagNone,
+                OptionSwitch(SetParallelIlxGenSwitch tcConfigB),
+                None,
+                Some(FSComp.SR.optsParallelIlxGen ())
+            )
+
+            CompilerOption(
+                "parallelreferenceresolution",
+                tagNone,
+                OptionSwitch(SetPparallelReferenceResolutionSwitch tcConfigB),
+                None,
+                Some(FSComp.SR.optsParallelReferenceResolution ())
+            )
         ]
 
     if isFsi then debug @ codegen else debug @ embed @ codegen

src/Compiler/FSComp.txt

@@ -933,6 +933,10 @@ optsEmitDebugInfoInQuotations,"Emit debug information in quotations"
 optsPreferredUiLang,"Specify the preferred output language culture name (e.g. es-ES, ja-JP)"
 optsNoCopyFsharpCore,"Don't copy FSharp.Core.dll along the produced binaries"
 optsSignatureData,"Include F# interface information, the default is file. Essential for distributing libraries."
+optsGraphTypeChecking,"Use graph typechecking."
+optsParallelOptimization,"Enable parallel optimization."
+optsParallelIlxGen,"Enable parallel IL generation."
+optsParallelReferenceResolution,"Enable parallel reference resolution."
 1046,optsUnknownSignatureData,"Invalid value '%s' for --interfacedata, valid value are: none, file, compress."
 optsOptimizationData,"Specify included optimization information, the default is file. Important for distributed libraries."
 1047,optsUnknownOptimizationData,"Invalid value '%s' for --optimizationdata, valid value are: none, file, compress."

src/Compiler/Optimize/Optimizer.fs

@@ -347,7 +347,7 @@ type OptimizationSettings =
           reportFunctionSizes = false
           reportHasEffect = false
           reportTotalSizes = false
-          processingMode = OptimizationProcessingMode.Sequential
+          processingMode = OptimizationProcessingMode.Parallel
         }
 
     /// Determines if JIT optimizations are enabled