Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph typechecking issue fix when using global namespace. #17553

Merged
merged 15 commits into from
Aug 19, 2024

Conversation

vzarytovskii
Copy link
Member

Test (and later fix) for the issue found in #17442

@vzarytovskii vzarytovskii requested a review from a team as a code owner August 16, 2024 17:22
Copy link
Contributor

github-actions bot commented Aug 16, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@vzarytovskii
Copy link
Member Author

@nojaf I figured that we can skip global when transforming LongIdent to path.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psfinaki
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants