Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness : downcasting should understand nullness information #17961

Merge branch 'main' into 17532-nullness-issue---downcasting-should-pr…

f60e50a
Select commit
Loading
Failed to load commit list.
Closed

Nullness : downcasting should understand nullness information #17961

Merge branch 'main' into 17532-nullness-issue---downcasting-should-pr…
f60e50a
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci (Build Source-Build (Managed)) failed Nov 6, 2024 in 6m 35s

Build Source-Build (Managed) failed

Annotations

Check failure on line 671 in artifacts/sb/src/src/Compiler/Utilities/TaggedCollections.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Compiler/Utilities/TaggedCollections.fs#L671

artifacts/sb/src/src/Compiler/Utilities/TaggedCollections.fs(671,50): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'obj | null' into 'Set<'T,'ComparerTag>' can introduce unexpected null values. Cast to 'Set<'T,'ComparerTag>|null' instead or handle the null before downcasting.

Check failure on line 1254 in artifacts/sb/src/src/Compiler/Utilities/TaggedCollections.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Compiler/Utilities/TaggedCollections.fs#L1254

artifacts/sb/src/src/Compiler/Utilities/TaggedCollections.fs(1254,18): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'obj | null' into 'Map<'Key,'T,'ComparerTag>' can introduce unexpected null values. Cast to 'Map<'Key,'T,'ComparerTag>|null' instead or handle the null before downcasting.

Check failure on line 484 in artifacts/sb/src/src/Compiler/AbstractIL/il.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Compiler/AbstractIL/il.fs#L484

artifacts/sb/src/src/Compiler/AbstractIL/il.fs(484,11): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'obj | null' into 'ILAssemblyRef' can introduce unexpected null values. Cast to 'ILAssemblyRef|null' instead or handle the null before downcasting.

Check failure on line 488 in artifacts/sb/src/src/Compiler/AbstractIL/il.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Compiler/AbstractIL/il.fs#L488

artifacts/sb/src/src/Compiler/AbstractIL/il.fs(488,22): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'obj | null' into 'ILAssemblyRef' can introduce unexpected null values. Cast to 'ILAssemblyRef|null' instead or handle the null before downcasting.

Check failure on line 753 in artifacts/sb/src/src/Compiler/AbstractIL/il.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build Source-Build (Managed))

artifacts/sb/src/src/Compiler/AbstractIL/il.fs#L753

artifacts/sb/src/src/Compiler/AbstractIL/il.fs(753,18): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'obj | null' into 'ILTypeRef' can introduce unexpected null values. Cast to 'ILTypeRef|null' instead or handle the null before downcasting.