Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness : downcasting should understand nullness information #17961

Closed
wants to merge 7 commits into from

Merge branch 'main' into 17532-nullness-issue---downcasting-should-pr…

f60e50a
Select commit
Loading
Failed to load commit list.
Closed

Nullness : downcasting should understand nullness information #17961

Merge branch 'main' into 17532-nullness-issue---downcasting-should-pr…
f60e50a
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci (Build WindowsNoRealsig_testCoreclr) failed Nov 6, 2024 in 9m 10s

Build WindowsNoRealsig_testCoreclr failed

27 errors / 0 warnings

Annotations

Check failure on line 1774 in src\Compiler\Checking\MethodCalls.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsNoRealsig_testCoreclr)

src\Compiler\Checking\MethodCalls.fs#L1774 

src\Compiler\Checking\MethodCalls.fs(1774,77): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'objnull' into 'string' can introduce unexpected null values. Cast to 'string|null' instead or handle the null before downcasting.

Check failure on line 171 in src\Compiler\DependencyManager\DependencyProvider.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsNoRealsig_testCoreclr)

src\Compiler\DependencyManager\DependencyProvider.fs#L171 

src\Compiler\DependencyManager\DependencyProvider.fs(171,42): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'objnull' into 'string array' can introduce unexpected null values. Cast to 'string array|null' instead or handle the null before downcasting.

Check failure on line 476 in src\Compiler\DependencyManager\DependencyProvider.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsNoRealsig_testCoreclr)

src\Compiler\DependencyManager\DependencyProvider.fs#L476 

src\Compiler\DependencyManager\DependencyProvider.fs(476,29): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'objnull' into 'string list' can introduce unexpected null values. Cast to 'string list|null' instead or handle the null before downcasting.

Check failure on line 477 in src\Compiler\DependencyManager\DependencyProvider.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsNoRealsig_testCoreclr)

src\Compiler\DependencyManager\DependencyProvider.fs#L477 

src\Compiler\DependencyManager\DependencyProvider.fs(477,29): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'objnull' into 'string list' can introduce unexpected null values. Cast to 'string list|null' instead or handle the null before downcasting.

Check failure on line 671 in src\Compiler\Utilities\TaggedCollections.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsNoRealsig_testCoreclr)

src\Compiler\Utilities\TaggedCollections.fs#L671 

src\Compiler\Utilities\TaggedCollections.fs(671,50): error FS3264: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullness warning: Downcasting from 'obj | null' into 'Set<'T,'ComparerTag>' can introduce unexpected null values. Cast to 'Set<'T,'ComparerTag>|null' instead or handle the null before downcasting.
View more details on Azure Pipelines