Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contributing.md #18043

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Add Contributing.md #18043

merged 7 commits into from
Nov 25, 2024

Conversation

KevinRansom
Copy link
Member

Fixes: #18042
We have mostly relied on DevGuide.md and TestGuide.md to layout technical information for the repo, but have never really providing a better discovery mechanism for new developers.

So looking around CONTRIBUTING.md seems to be a thing, here is ours:

@KevinRansom KevinRansom requested a review from a team as a code owner November 21, 2024 20:33
@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

edgarfgp
edgarfgp reviewed Nov 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
T-Gro
T-Gro reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
T-Gro
T-Gro reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
psfinaki
psfinaki reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
psfinaki
psfinaki reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
psfinaki
psfinaki reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
vzarytovskii
vzarytovskii reviewed Nov 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
KevinRansom and others added 5 commits November 22, 2024 09:32
@KevinRansom @T-Gro
Update CONTRIBUTING.md
a73deb4 
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
@KevinRansom @vzarytovskii
Update CONTRIBUTING.md
fb65b79 
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
@KevinRansom
Merge branch 'main' into contributing
461a662
@KevinRansom @psfinaki
Update CONTRIBUTING.md
925ac46 
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
@KevinRansom
Update CONTRIBUTING.md
40647f5
psfinaki
psfinaki approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my side, resolved my comments.

We can iterate on this.

@abonie abonie merged commit af90690 into dotnet:main Nov 25, 2024
33 checks passed
psfinaki added a commit that referenced this pull request Nov 28, 2024
@dotnet-bot @ellahathaway
@psfinaki @0101 @teo-tsirpanis @KevinRansom @majocha @T-Gro @vzarytovskii @dotnet-maestro @BoundedChenn31
Merge main to release/dev17.13 (#18080)
3dc980e 
* Add -sign to build.sh (#18024)

* Fix singing problems (#18040)

* Skip flaky test (#18051)

* Remove support for `System.AggressiveAttributeTrimming` feature switch. (#18039)

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* Update some internal guidelines (#18052)

* simplify temp dirs in service (#18046)

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

* Add Contributing.md (#18043)

* contributing

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>

* Update CONTRIBUTING.md

Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* Update CONTRIBUTING.md

---------

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* [main] Update dependencies from dotnet/arcade (#17729)

* Update dependencies from https://github.com/dotnet/arcade build 20240913.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24462.3 -> To Version 9.0.0-beta.24463.2

* Update dependencies from https://github.com/dotnet/arcade build 20240916.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24463.2 -> To Version 9.0.0-beta.24466.2

* Update dependencies from https://github.com/dotnet/arcade build 20240923.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24466.2 -> To Version 9.0.0-beta.24473.1

* Update dependencies from https://github.com/dotnet/arcade build 20241001.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24473.1 -> To Version 9.0.0-beta.24501.3

* Update dependencies from https://github.com/dotnet/arcade build 20241003.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24501.3 -> To Version 9.0.0-beta.24503.2

* Update dependencies from https://github.com/dotnet/arcade build 20241008.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24503.2 -> To Version 9.0.0-beta.24508.3

* Update dependencies from https://github.com/dotnet/arcade build 20241009.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24508.3 -> To Version 9.0.0-beta.24509.3

* Update dependencies from https://github.com/dotnet/arcade build 20241016.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24509.3 -> To Version 9.0.0-beta.24516.2

* Update dependencies from https://github.com/dotnet/arcade build 20241112.13

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24462.3 -> To Version 9.0.0-beta.24562.13

* Update dependencies from https://github.com/dotnet/arcade build 20241122.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24462.3 -> To Version 9.0.0-beta.24572.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

* Refactor AsyncMemoize, introduce AsyncLazy (#18002)

* refactor AsyncMemoize, introduce AsyncLazy

* use lock free mb in tests

* remove unnecessary prop

* update il baselines

* rename

* add requestCount name

Co-authored-by: Petr Pokorny <petr@innit.cz>

* improve as reviewed

* lock for TryGet

* more locks

* ilverify

* deallocate computation when completed

* ilverify

* style

* typo

---------

Co-authored-by: Petr Pokorny <petr@innit.cz>

* Fix crashdump paths in CI (#18065)

* Various updates to ILVerify (#18060)

* Update azure-pipelines-PR.yml

* Add null annotation to Async.SwitchToContext (#18059)

---------

Co-authored-by: Ella Hathaway <67609881+ellahathaway@users.noreply.github.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
Co-authored-by: Petr Pokorny <petrpokorny@microsoft.com>
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: Jakub Majocha <1760221+majocha@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Petr Pokorny <petr@innit.cz>
Co-authored-by: Ch13 <boundedchenn31@gmail.com>
This was referenced Dec 13, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii left review comments

@T-Gro T-Gro T-Gro approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a contributing.md
6 participants
@KevinRansom @vzarytovskii @psfinaki @edgarfgp @T-Gro @abonie