Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashdump paths in CI #18065

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

vzarytovskii
Copy link
Member

Hardcode configuration, when we only build one (and don't have $(_configuration), so path ends up being invalid), should help investigating #17872 (comment)

@vzarytovskii vzarytovskii requested a review from a team as a code owner November 26, 2024 15:48
Copy link
Contributor

✅ No release notes required

@vzarytovskii
Copy link
Member Author

CI can be skipped here, since it parses ok, it will just fix paths, I'm gonna force merge it so we can collect dumps

@vzarytovskii vzarytovskii merged commit ebdd536 into dotnet:main Nov 26, 2024
6 of 32 checks passed
@vzarytovskii vzarytovskii deleted the fix-crashdumps branch November 26, 2024 15:52
@vzarytovskii vzarytovskii mentioned this pull request Nov 26, 2024
8 tasks
psfinaki added a commit that referenced this pull request Nov 28, 2024
* Add -sign to build.sh (#18024)

* Fix singing problems (#18040)

* Skip flaky test (#18051)

* Remove support for `System.AggressiveAttributeTrimming` feature switch. (#18039)

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* Update some internal guidelines (#18052)

* simplify temp dirs in service (#18046)

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

* Add Contributing.md (#18043)

* contributing

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>

* Update CONTRIBUTING.md

Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* Update CONTRIBUTING.md

---------

Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* [main] Update dependencies from dotnet/arcade (#17729)

* Update dependencies from https://github.com/dotnet/arcade build 20240913.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24462.3 -> To Version 9.0.0-beta.24463.2

* Update dependencies from https://github.com/dotnet/arcade build 20240916.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24463.2 -> To Version 9.0.0-beta.24466.2

* Update dependencies from https://github.com/dotnet/arcade build 20240923.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24466.2 -> To Version 9.0.0-beta.24473.1

* Update dependencies from https://github.com/dotnet/arcade build 20241001.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24473.1 -> To Version 9.0.0-beta.24501.3

* Update dependencies from https://github.com/dotnet/arcade build 20241003.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24501.3 -> To Version 9.0.0-beta.24503.2

* Update dependencies from https://github.com/dotnet/arcade build 20241008.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24503.2 -> To Version 9.0.0-beta.24508.3

* Update dependencies from https://github.com/dotnet/arcade build 20241009.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24508.3 -> To Version 9.0.0-beta.24509.3

* Update dependencies from https://github.com/dotnet/arcade build 20241016.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24509.3 -> To Version 9.0.0-beta.24516.2

* Update dependencies from https://github.com/dotnet/arcade build 20241112.13

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24462.3 -> To Version 9.0.0-beta.24562.13

* Update dependencies from https://github.com/dotnet/arcade build 20241122.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24462.3 -> To Version 9.0.0-beta.24572.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>

* Refactor AsyncMemoize, introduce AsyncLazy (#18002)

* refactor AsyncMemoize, introduce AsyncLazy

* use lock free mb in tests

* remove unnecessary prop

* update il baselines

* rename

* add requestCount name

Co-authored-by: Petr Pokorny <petr@innit.cz>

* improve as reviewed

* lock for TryGet

* more locks

* ilverify

* deallocate computation when completed

* ilverify

* style

* typo

---------

Co-authored-by: Petr Pokorny <petr@innit.cz>

* Fix crashdump paths in CI (#18065)

* Various updates to ILVerify (#18060)

* Update azure-pipelines-PR.yml

* Add null annotation to Async.SwitchToContext (#18059)

---------

Co-authored-by: Ella Hathaway <67609881+ellahathaway@users.noreply.github.com>
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
Co-authored-by: Petr Pokorny <petrpokorny@microsoft.com>
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: Jakub Majocha <1760221+majocha@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Petr Pokorny <petr@innit.cz>
Co-authored-by: Ch13 <boundedchenn31@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant